Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] Add support for Samsung DeX mode #5777

Merged
merged 1 commit into from Dec 15, 2023

Conversation

meenbeese
Copy link
Contributor

Signed-off-by: meenbeese meenbeese@tutanota.com

Resolves #2218 by adding basic but working support for DeX mode.

@rtsisyk
Copy link
Contributor

rtsisyk commented Aug 21, 2023

I have a Samsung device with DEX, let me test it.

@rtsisyk rtsisyk self-requested a review August 21, 2023 05:31
android/AndroidManifest.xml Outdated Show resolved Hide resolved
android/AndroidManifest.xml Outdated Show resolved Hide resolved
android/AndroidManifest.xml Outdated Show resolved Hide resolved
android/AndroidManifest.xml Outdated Show resolved Hide resolved
@rtsisyk rtsisyk self-assigned this Aug 28, 2023
Copy link
Member

@Jean-BaptisteC Jean-BaptisteC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Samsung Galaxy Tab S6 Lite - Android 13 (Mode Dex)
✅ Pixel 6 - Android 14

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that your changes are related to every OM user, not just a few DeX users. That's why it is critically important to test it properly with and without DeX mode.

Signed-off-by: meenbeese <meenbeese@tutanota.com>
@meenbeese
Copy link
Contributor Author

Note that your changes are related to every OM user, not just a few DeX users. That's why it is critically important to test it properly with and without DeX mode.

It looks like the changes work fine for @Jean-BaptisteC . We can also always roll it to beta users first and collect feedback from them.

@rtsisyk rtsisyk added this to the Next Release milestone Nov 23, 2023
@rtsisyk
Copy link
Contributor

rtsisyk commented Dec 15, 2023

It works very well!

Screenshot_20231215-174348_Organic Maps (Debug)
Screenshot_20231215-174430_Organic Maps (Debug)
Screenshot_20231215-174638_Organic Maps (Debug)

Thanks for the contribution. Merged.

@rtsisyk rtsisyk merged commit ae9172e into organicmaps:master Dec 15, 2023
4 checks passed
@meenbeese meenbeese deleted the samsung-dex branch December 15, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suport Samsung DeX mode for Android
4 participants