[ios][android] Add fee indicator to Place Page and search results

[dvdmrtnz]

This PR adds a fee indicator to the Place Page in iOS. This icon will show in any place that has a fee=yes property.

• Related to More POI info for toilets and showers #3192

• Closes Display toilet fee #2707

• Closes show at least unusual fee=* info: fee=yes on tourism=viewpoint in object description, show fee=no for museums #5308

[matheusgomesms]

Great job!!! I always wanted that differentiation! Regarding the icon, I would personally use the dollar sign. I think it’s more recognizable than the bag one.

[dvdmrtnz]

Great job!!! I always wanted that differentiation! Regarding the icon, I would personally use the dollar sign. I think it’s more recognizable than the bag one.

🤔 I’m thinking that maybe it could be better to have it in text: Fee/No fee. That way we could have info about the feature being free, as opposed to no info available. Because I don’t thing there is a suitable "No fee" icon. WDYT?

[dvdmrtnz]

I've changed it to a localized Paid/Free text.

[RedAuburn]

I've changed it to a localized Paid/Free text.

this looks good :)

[Jean-BaptisteC]

What about Android?

[dvdmrtnz]

What about Android?

I’m not 100% sure but I think it should actually work in Android with these changes, since I’ve made this modification in the c++ core

[Jean-BaptisteC]

I see nothing on Android with latest build

[dvdmrtnz]

I see nothing on Android with latest build

Maps need to be regenerated because there is a new metadata property

[map-per]

Added a suggestion for the german translation

[dvdmrtnz]

I see nothing on Android with latest build

I just tested it on Android. A minor change was needed, and now it works there too.

[biodranik]

Did you see #1312 and #2254 ?

How important is it to be able to quickly search by the value of the fee tag?

[dvdmrtnz]

Did you see #1312 and #2254 ?

How important is it to be able to quickly search by the value of the fee tag?

Yes, I saw those threads. I guess that you are asking me this because I took the "metadata" approach to adding this info, instead of adding it as a "type", right? I thought it was easier to add fee=* as metadata property and more scalable (given the limit of 7 types per feature), specially if we want to add some more properties like takeaway=*, delivery=*, capacity=*, drive_through=* and similar properties of other bigger places.

[biodranik]

fee is important for some other types too like parkings, toilets, etc. Using metadata in the search is possible, but it will be very slow.

[vng]

UI - no problem here.

I'm planning to refactor fee, access, etc #1312

Storing fee in metadata is not a good idea. At least because of fast reading for rendering. I'm sure, we will render some dynamic icons someday depending on these tags.

[dvdmrtnz]

UI - no problem here.

I'm planning to refactor fee, access, etc #1312

Storing fee in metadata is not a good idea. At least because of fast reading for rendering. I'm sure, we will render some dynamic icons someday depending on these tags.

Okay. I guess we'll have to wait until the fee refactoring then.

[pastk]

Storing fee in metadata is not a good idea. At least because of fast reading for rendering. I'm sure, we will render some dynamic icons someday depending on these tags.

I think this solution is fine for the interim.

The fee/access refactoring mentioned is a very long shot. And dynamic icons is even longer one :) No need to wait for them when we can improve UX now.

Code changes in this PR are small, so no problem to re-do when we have a new system in place.

[pastk]

We've been discussing it and decided that adding separate fee-yes/fee-no types seems to be a better long-term approach.

[dvdmrtnz]

We've been discussing it and decided that adding separate fee-yes/fee-no types seems to be a better long-term approach.

I have tried adding to mapcss-mapping.csv:

fee|yes;[fee=yes];;name;int_name;1583;
fee|no;[fee=no];;name;int_name;1584;

But it doesn't seem to be working 🤔. I have regenerated maps and everything but it doesn't show up in the raw types. Any idea why?

https://www.openstreetmap.org/node/9341902098#map=19/42.81552/-1.64178

[pastk]

But it doesn't seem to be working 🤔. I have regenerated maps and everything but it doesn't show up in the raw types. Any idea why?

Types that don't have any styles defined are discarded by the generator.
So you've got to add these new types into "exceptions" alongside cuisine and wheelchair in indexer/feature_visibility.cpp::IsUsefulNondrawableType().

Please add a note about this behavior into the comment in the mapcss-mapping.csv.

Also note that its better to use fee|yes;[fee?];... as it'll include non-yes values like fee=10 (basically everything except fee=no).

[dvdmrtnz]

@pastk @vng @biodranik PTAL. Now using fee-yes, fee-no types, instead of metadata

[dvdmrtnz]

Seems to me like a double-negative but Iet's see if any of those will get displayed properly...

0024+043F+20E0: $͏⃠ 0024+FEFF+20E0: $⃠ 0024+2060+20E0: $⁠⃠ 1F4B2+2060+20E0: 💲⁠⃠ 1F10F: 🄏

I'd go for option 5. or 7. too, though.

[pastk]

IMHO none of those look good enough... Also their display might be dependent on available fonts, isn't it?

It might look OK if we make our own clean looking icon with a crossed dollar sign. But at the expense of hardcoding its display. And I don't think its worth it, a textual "Free" is a better option IMO.

[dvdmrtnz]

Some more options:

\u0024\u20dd
$⃝

\u0024\u20e3
$⃣

\u0024\u20e5
$⃥

\u0024\u20ea
$⃪

\u0024\u20eb
$⃫

\u0024\u0336
$̶

\u0024\u20dd\u20e5
$⃝⃥

\u0024\u20dd\u0336
$⃝̶

\u0024\u20dd\u20eb
$⃝⃫

It's quite funny what you can do with unicode and diacritics 🤣. Here's the list of unicode diacritics: https://en.wikipedia.org/wiki/Diacritic#List_of_diacritics_in_Unicode

By the way I am using this website to try out the characters: https://www.branah.com/unicode-converter

Some of these look okay in iOS but then look quite bad on Android 😂

[dvdmrtnz]

I'm setting it as Toilet • Free / Toilet • 💲 / Toilet

[biodranik]

@vng PTAL

[vng]

LGTM