[android] capitalise each word in editable name fields #5946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capitalising each word makes much more sense for name fields, as names are usually in title case Signed-off-by: Harry Bond <endim8@pm.me>
RedAuburn
changed the title
It makes sense for English, maybe German, but not for all languages.
|
ah, you're right. In StreetComplete (streetcomplete/StreetComplete#4784) they recently switched away from word case as they decided it was too much effort to fix for too little gain, so the current sentence casing will do :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capitalising each word makes much more sense for name fields, as names are usually in title case. (this is also the default in StreetComplete)
screen-20230905-120556.1.mp4