Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[strings] Update editor_edits_sent_message string #6993

Merged
merged 2 commits into from
Apr 2, 2024
Merged

[strings] Update editor_edits_sent_message string #6993

merged 2 commits into from
Apr 2, 2024

Conversation

MontakOleg
Copy link
Contributor

Update editor_edits_sent_message string to reflect real app behavior (updates will be sent when the app goes to the background), as suggested in comment #6986 (comment)

@MontakOleg MontakOleg force-pushed the update-editor_edits_sent_message-string branch 2 times, most recently from dc91734 to db568b6 Compare December 27, 2023 16:00
@MontakOleg MontakOleg changed the title Update editor_edits_sent_message string [strings] Update editor_edits_sent_message string Dec 27, 2023
@MontakOleg MontakOleg mentioned this pull request Dec 27, 2023
Merged
biodranik
biodranik approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Calling for reviews from @organicmaps/translations

fitojb
fitojb suggested changes Dec 28, 2023
View reviewed changes
data/strings/strings.txt Outdated Show resolved Hide resolved
data/strings/strings.txt Outdated Show resolved Hide resolved
vgrigoriu
vgrigoriu reviewed Dec 28, 2023
View reviewed changes
data/strings/strings.txt Outdated Show resolved Hide resolved
@MontakOleg MontakOleg force-pushed the update-editor_edits_sent_message-string branch 2 times, most recently from c228069 to b6b8b63 Compare December 28, 2023 11:49
jimcarst
jimcarst approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@jimcarst jimcarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for nl

@MontakOleg MontakOleg force-pushed the update-editor_edits_sent_message-string branch from b6b8b63 to 8c5bac8 Compare December 28, 2023 17:14
d4f5409d
d4f5409d suggested changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@d4f5409d d4f5409d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hu needs changes

iphone/Maps/LocalizedStrings/hu.lproj/Localizable.strings Outdated
@@ -811,7 +811,7 @@

"placepage_delete_bookmark_button" = "Könyvjelző törlése";

"editor_edits_sent_message" = "Javasolt változtatásainak elküldése sikerült";
"editor_edits_sent_message" = "Az Ön megjegyzése elküldésre kerül az OpenStreetMap-nek";
Copy link
Contributor

@d4f5409d d4f5409d Dec 29, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"editor_edits_sent_message" = "Az Ön megjegyzése elküldésre kerül az OpenStreetMap-nek";
"editor_edits_sent_message" = "Az Ön változtatási javaslata elküldésre fog kerülni";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, DeepL says that Az Ön változtatási javaslata elküldésre került means Your change proposal has been sent.

But we want to emphasize that change is not sent yet, it will be sent at some time in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d4f5409d happy new year! Waiting for your response here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HNY! Don't rely on DeepL that much, it isn't 100% perfect ;)
I changed the translation accordingly to your review.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated ✔️

data/strings/strings.txt Outdated Show resolved Hide resolved
@MontakOleg MontakOleg force-pushed the update-editor_edits_sent_message-string branch from 8c5bac8 to edeb5b7 Compare January 8, 2024 15:46
@MontakOleg
Copy link
Contributor Author

@biodranik hi! Are we waiting for more reviews or can proceed with merging this?

@Jean-BaptisteC
Copy link
Member

@biodranik PTAL

@Jean-BaptisteC
Copy link
Member

@MontakOleg can you rebase your branch?

@MontakOleg
[strings] Update editor_edits_sent_message string
9d9b0e1 
Signed-off-by: Oleg Montak <oleg.montak@gmail.com>
@MontakOleg MontakOleg force-pushed the update-editor_edits_sent_message-string branch from edeb5b7 to 08171f7 Compare April 2, 2024 20:23
@MontakOleg
Copy link
Contributor Author

@Jean-BaptisteC yep, rebased.

@MontakOleg MontakOleg force-pushed the update-editor_edits_sent_message-string branch from 08171f7 to 904c456 Compare April 2, 2024 20:25
@Jean-BaptisteC
Copy link
Member

@biodranik ready to merge

biodranik
biodranik approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@biodranik
Copy link
Member

@MontakOleg can you please squash/fixup two last commits before the merge?

@MontakOleg
[strings] regen strings
c9c5ca6 
Signed-off-by: Oleg Montak <oleg.montak@gmail.com>
@MontakOleg MontakOleg force-pushed the update-editor_edits_sent_message-string branch from 904c456 to c9c5ca6 Compare April 2, 2024 21:26
@MontakOleg
Copy link
Contributor Author

@biodranik Sure! Done.

@biodranik biodranik merged commit 7ac7d34 into organicmaps:master Apr 2, 2024
6 checks passed
@MontakOleg MontakOleg deleted the update-editor_edits_sent_message-string branch May 15, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgrigoriu vgrigoriu vgrigoriu left review comments

@d4f5409d d4f5409d d4f5409d requested changes

@matheusgomesms matheusgomesms matheusgomesms left review comments

@fitojb fitojb fitojb requested changes

@biodranik biodranik biodranik approved these changes

@proxygeek proxygeek proxygeek approved these changes

@jimcarst jimcarst jimcarst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@MontakOleg @Jean-BaptisteC @biodranik @vgrigoriu @proxygeek @fitojb @jimcarst @d4f5409d @matheusgomesms