Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[strings] Update strings.txt EU #7399

Merged
merged 2 commits into from
Apr 25, 2024
Merged

[strings] Update strings.txt EU #7399

merged 2 commits into from
Apr 25, 2024

Conversation

garaolaza
Copy link
Contributor

Some translation corrections in the "eu" version

@garaolaza garaolaza changed the title Update strings.txt EU [strings] Update strings.txt EU Feb 16, 2024
biodranik
biodranik approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

biodranik
biodranik reviewed Feb 16, 2024
View reviewed changes
data/strings/strings.txt Outdated Show resolved Hide resolved
@Jean-BaptisteC
Copy link
Member

@garaolaza can you remove whitespaces?

rtsisyk
rtsisyk reviewed Mar 6, 2024
View reviewed changes
data/strings/strings.txt Outdated Show resolved Hide resolved
rtsisyk
rtsisyk reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@rtsisyk rtsisyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion.

@garaolaza garaolaza marked this pull request as draft April 25, 2024 11:44
@garaolaza garaolaza marked this pull request as ready for review April 25, 2024 11:49
garaolaza
garaolaza commented Apr 25, 2024
View reviewed changes
Copy link
Contributor Author

@garaolaza garaolaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Gari Araoalza garaolaza@codesyntax.com

@garaolaza garaolaza marked this pull request as draft April 25, 2024 12:23
garaolaza
garaolaza commented Apr 25, 2024
View reviewed changes
Copy link
Contributor Author

@garaolaza garaolaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Gari Araolaza garaolaza@codesyntax.com

@garaolaza
Copy link
Contributor Author

Sorry, I did not receive the notifications on your comments.

I am afraid I need some help to contribute these changes, as I am not familiar with PR's.

biodranik
biodranik approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you did it well!

@biodranik biodranik marked this pull request as ready for review April 25, 2024 19:56
@biodranik
Copy link
Member

Looks like there is a merge conflict, as the file has been already changed. Let me help you.

garaolaza and others added 2 commits April 25, 2024 22:03
@garaolaza @biodranik
Update strings.txt EU
1dbe467 
Some translation corrections in the "eu" version

Signed-off-by: garaolaza <garaolaza@codesyntax.com>
@biodranik
[strings] Regenerated
40d7568 
Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik biodranik merged commit 06598a2 into organicmaps:master Apr 25, 2024
9 checks passed
@biodranik
Copy link
Member

Thank you for your contribution and welcome to the club )

@garaolaza
Copy link
Contributor Author

Thank you @biodranik ! I love Organic Maps and I would like to help.

@garaolaza garaolaza deleted the patch-1 branch April 26, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtsisyk rtsisyk rtsisyk approved these changes

@biodranik biodranik biodranik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garaolaza @Jean-BaptisteC @biodranik @rtsisyk