Use char32_t instead of uint32_t for UniChar #7423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biodranik
commented
Feb 18, 2024
|
@zyphlar PTAL, this can make your code simpler. |
vng
reviewed
Feb 25, 2024
biodranik
force-pushed
the
ab-unichar-to-char32_t
branch
2 times, most recently
from
b2c36df
to
cac8dee
Compare
vng
reviewed
Feb 25, 2024
| std::istringstream stream((std::string(*semicolon))); | ||
| strings::UniChar uc; | ||
| const std::string iString{*semicolon}; | ||
| std::istringstream stream(iString); |
There was a problem hiding this comment.
nit: What was wrong with previous std::istringstream stream((std::string(*semicolon))) ?
vng
approved these changes
Feb 25, 2024
|
glyph_manager.cpp fix should be simple, just read uint32_t |
biodranik
force-pushed
the
ab-unichar-to-char32_t
branch
from
cac8dee
to
b0ff0cb
Compare
vng
reviewed
Feb 25, 2024
That allows to use u32string_view in the code, adding useful std::basic_string_view methods Signed-off-by: Alexander Borsuk <me@alex.bio>
biodranik
force-pushed
the
ab-unichar-to-char32_t
branch
from
b0ff0cb
to
32711d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That allows to use std::u32string_view in the code, adding useful std::basic_string_view methods