All German translations in strings have been reviewed #7529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j13m126
suggested changes
Mar 6, 2024
Misalf-git
reviewed
Mar 6, 2024
|
Added my mustard as well. I hope it worked this time. |
Vielen Dank, @Misalf-git und @j13m126 🙏 It's now implemented and ready to merge |
|
Please try to reach the consensus with @organicmaps/translations-de. |
j5k
reviewed
Mar 10, 2024
patepelo
requested review from
j13m126,
j5k and
Misalf-git
and removed request for
j5k
|
@patepelo could you finish it please? or do you need help? |
|
As a german speaking person the changes are all valid an better than the text before. |
Yes, give me until tomorrow to try on my own with all the git commands and if I get stuck again, I'll contact you for help 👍 |
Signed-off-by: Anton <antonwenemoser@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
pastk
force-pushed
the
german_translations_review
branch
from
750ea0c
to
0a56855
Compare
|
Ready to merge! |
Many many thanks, @pastk 🙏 |
biodranik
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The German translation has been reviewed, and many terms have been asked to the DACH (German speaking) community.
A brief review from another German speaker is requested and appreciated.