[android] Simplify TTS code using AudioManagerCompat #7575
Conversation
|
Is it really necessary to use media library, we try to reduce as possible the size of APK |
It provides consistent behaviour across Android versions when requesting/abandoning audio focus. On the other hand, it'll increase the app size slightly as mentioned, though this impact can be reduced with code shrinking. |
|
I meant that it avoids the need to call a deprecated API directly (the compat class handles that scenario), and it makes the transition to the framework API easier when the minSdk is bumped to 26 or higher.
I'm having issues with building the app, as it's complaining about Boost being missing (I'm building on Windows, and I've cloned the repos for the 3rd party dependencies). That being said, there shouldn't be a significant increase in the size of the app (maybe a few kilobytes) or cause any issues on different Android versions (it's from a library developed by Google, and the new focus request is in the same format as the original version). |
|
Let's measure the size to be precise. Did you follow all documentation instructions about cloning and configuring the project? |
Yes, I followed all the instructions under the Android section (I installed the NDK and CMake, and I'm using Android Studio). Edit: I cloned again and ran the configuration script, but during the build it's still complaining about Boost being missing. |
|
What build error do you see? |
It's complaining about Boost being missing, but the repo was properly cloned with the third party dependencies. |
|
It means that |
I ran the script using WSL, and there didn't seem to be any issues (no error messages or anything like that). |
|
Please paste 1) the script's output and 2) the build error output. |
|
Configure script output (I already ran it when setting up the repo): Build errors: |
|
Try to move the organicmaps repository folder into another location, without spaces in the path (you have a parent |
I tried removing the spaces, but it still gives the error messages about Boost not being available. |
|
How do you run configure.sh? Does it create files in 3party/boost subdirectory accessible for Android Studio? |
I run it through the WSL terminal. The created directories are visible in Android Studio.
|
|
The error message in your build log explicitly says that file does not exist: Please check the existence of this file at this path. If configure was run properly, then this file (and others) should exist. As boost uses symlinks, I assume that symlinks may not be enabled in your system, like it was mentioned in the documentation. |
I enabled symlinks in Git using the command mentioned in the documentation. Also, the file is there:
|
|
Symlinks should be also enabled in the operating system. Are you able to see that file's content when you click it in Android Studio? |
Developer mode wasn't enabled. I enabled it, and now the build is working. Edit - Here are the app sizes: Before: 60426 KB |
Isira-Seneviratne
force-pushed
the
AudioManagerCompat
branch
from
8591238
to
3cf1685
Compare
| mTts.speak(textToSpeak, TextToSpeech.QUEUE_ADD, mParams, textToSpeak); | ||
| final boolean isMusicActive = mAudioManager.isMusicActive(); | ||
| AudioManagerCompat.requestAudioFocus(mAudioManager, mAudioFocusRequest); | ||
| final long delay = isMusicActive ? TTS_SPEAK_DELAY_MILLIS : 0; |
There was a problem hiding this comment.
What does git blame/git log say about this delay when music is active? Why was it introduced in the first place? Is this delay really needed?
There was a problem hiding this comment.
That delay was introduced in this 2021 commit: 959dc08
|
@Isira-Seneviratne can you rebase your branch? |
Signed-off-by: Isira Seneviratne <isirasen96@gmail.com>
Isira-Seneviratne
force-pushed
the
AudioManagerCompat
branch
from
3cf1685
to
81277f3
Compare
|
Thank you for your patience. I don't have cycles to test this PR fully at the moment. Let's wait until other folks make the first round of testing. |
AudioManagerCompatandAudioFocusRequestCompat.