[android-auto] Fix some bugs #7671
Conversation
Signed-off-by: Andrew Shkrob <andrew.shkrob.social@yandex.by>
| @@ -220,7 +220,7 @@ public void enable() | |||
| mMap.onStart(); | |||
| mMap.setCallbackUnsupported(this::reportUnsupported); | |||
| mMap.setMapRenderingListener(this); | |||
| mMap.updateMyPositionRoutingOffset(0); | |||
| UiThread.runLater(() -> mMap.updateMyPositionRoutingOffset(0)); | |||
There was a problem hiding this comment.
Why this one only?
I suppose that mMap.updateMyPositionRoutingOffset call is semantically the same as mMap.setMapRenderingListener, no?
There was a problem hiding this comment.
All this code is run in the UI thread anyway but I want to schedule this function call for a later not overcross with the same call from the device which may break the offset for AA. But I covered the device's call with if (isDeviceDisplayUsed). So, it shouldn't be a problem but to be 100% sure
There was a problem hiding this comment.
Please add an explaining comment into the code, it looks unclear.
There was a problem hiding this comment.
All these UiThread.runLater() look like a magic, but I understand this issue. Please add a comment and we can merge this PR.
Closes: #7470
Fixed a bug with the routing controller detached when switching from the device to the car screen
How to test: