Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Fix the tappable area for the color selection icon in the Edit mode #7683

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

kirylkaveryn
Copy link
Contributor

Issue:

When a user enables the editing mode on the Bookmarks screen and taps on the delete button the color picking is starting instead of deleting.

Thus PR fixes this issue.

Tested on:

  • iPhone 11pro (device)
  • iPhone 6 (device)
  • iPhone 15pro (sim)
  • macOS

Result:

Simulator Screen Recording - iPhone 15 Pro - 2024-03-25 at 13 10 32

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
@kirylkaveryn kirylkaveryn added iOS iOS development UI User interface issues labels Mar 25, 2024
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🔥

@rtsisyk rtsisyk merged commit 55c719a into master Apr 4, 2024
5 checks passed
@rtsisyk rtsisyk deleted the ios/fix-bookmarks-deleting-from-edit-issue branch April 4, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS development UI User interface issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants