-
-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android][editor] 'No suitable category' info #7748
Conversation
nice! it might be good if there was a button to add a note from that screen too :) |
Isn't the "category" word confusing in this context? |
The "category" wording comes from the search tab. Using a different word requires replacing it everywhere consistently. Most users do not know what "lines, areas, tags, features, OSM" mean, and won't understand the text. Only those who are already familiar with OSM will read it properly. |
I think "category" is better here for users who don't know the more OSM specific / more technical term "feature type".
That's right. Let's use this text: "Organic Maps does not support all categories. E.g. cities, railway stations, roads, lakes, or buildings can not be added. Please add such features directly via osm.org (use the Edit button in the top bar) or use a specialized OSM editing app." |
I updated the text and added translations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for nl
Should we recommend other OSM editors here and provide links to them? |
What about linking OSM Wiki https://wiki.openstreetmap.org/wiki/Editors ? |
data/strings/strings.txt
Outdated
|
||
[editor_category_unsuitable_text1] | ||
tags = android | ||
en = Organic Maps does not support all categories. E.g. cities, railway stations, roads, lakes, or buildings can not be added. Please add such features directly via osm.org (use the Edit button in the top bar) or use a specialized OSM editing app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe first sentence like
Organic Maps allows to add simple point features only, that means no towns, roads, lakes, building outlines, etc.
?
Please add such features directly via osm.org (use the Edit button in the top bar) or use
Here I read it like there is an Edit button in OM's top bar that'll get me to the right place in osm.org... Maybe drop the (use the Edit button in the top bar)
completely? or rephrase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"objects" then is clearer for newbies than a highly specific term "features".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"objects", "map objects", "object types", etc. should be good indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second the suggestion for the first sentence, clarifying that only points are supported. Here's my edit to the suggestion:
en = Organic Maps does not support all categories. E.g. cities, railway stations, roads, lakes, or buildings can not be added. Please add such features directly via osm.org (use the Edit button in the top bar) or use a specialized OSM editing app. | |
en = Organic Maps can only add point features, not lines or shapes. This means you cannot add roads, buildings, cities, railway stations, or lakes, among other things. Please add such features directly via osm.org (use the Edit button in the top bar of the website) or use a specialized OSM editing app. |
I've also made roads and buildings first in the list of examples (they get the point across better than cities IMO) and clarified the top bar as noted.
Edit: if you don't like features, it can just be: "Organic Maps can only add points, not lines or shapes."
First, I like the idea very much. The panel stands out, and serves a good introduction to where the data goes. What'd I improve is shifting the focus from the website (we're on a phone remember) to apps. It should mention 2-3 most prominent mapping alternatives on the platform, different for iOS and Android: StreetComplete, Vespucci, Go Map, Every Door. But that might make the panel too big, so we might consider making a dedicated page, and here just put a link. E.g. "To add or edit features of all types consider installing a dedicated app...". Also, you can add notes with Organic Maps, so it should be a button, not a link. |
<string name="editor_category_unsuitable_title">Nu găsiți o categorie potrivită?</string> | ||
<string name="editor_category_unsuitable_text1">Organic Maps nu acceptă toate categoriile. De exemplu, nu pot fi adăugate orașe, gări, drumuri, lacuri sau clădiri. Vă rugăm să adăugați astfel de caracteristici direct prin osm.org (utilizați butonul Edit din bara de sus) sau să folosiți o aplicație specializată de editare OSM.</string> | ||
<string name="editor_category_unsuitable_text2">Alternativ, puteți utiliza și OSM Notes (osm.org/wiki/Notes) pentru rapoarte către comunitatea OSM.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ro translation looks good.
Re "categories" vs "feature types" vs "object types". Using "objects" or "features" sounds good to me. However when people will eventually proceed to osm.org (and we want them to do it) for wiki, beginner guide, editor, support chats, etc. they will have to re-learn to "map features" again. So I'd rather start with the "osm standard term" "features" right away, IMHO its very understandable given the context and eventually there will be less confusion created by different terms usage. My suggestion:
(as OM doesn't support leaving standalone Notes yet then its better to drop this part IMO) The "Category" caption ( And its better to replace the "Search" text inside the search field with a hint like |
If there is a concern that a "feature" is ambiguous / not specific enough then just use a "map feature"? |
Good catch with the phone, ID is unusable on a phone (you have to rotate your phone all the time to access buttons). But I would rather suggest users to use ID on a PC as all Android apps can either not edit everything (StreetComplete, Every Door, OSM Go!) or are very complicated to use (Vespucci, OSM Go!). (Go Map is ios only) We could also add a link to the Beginners Guide in the OSM Wiki |
A detailed page on OM website may be better than everything else, because:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇭🇺❌
@@ -490,6 +490,9 @@ | |||
<string name="editor_detailed_description">Javasolt változtatásait elküldjük az OpenStreetMap közösségnek. Írja le a további információkat, amelyek nem szerkeszthetők a Organic Maps-ben.</string> | |||
<string name="editor_more_about_osm">További részletek az OpenStreetMap-ról</string> | |||
<string name="editor_operator">Üzemeltető</string> | |||
<string name="editor_category_unsuitable_title">Nem talál megfelelő kategóriát?</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string name="editor_category_unsuitable_title">Nem talál megfelelő kategóriát?</string> | |
<string name="editor_category_unsuitable_title">Nem találja a megfelelő kategóriát?</string> |
@@ -490,6 +490,9 @@ | |||
<string name="editor_detailed_description">Javasolt változtatásait elküldjük az OpenStreetMap közösségnek. Írja le a további információkat, amelyek nem szerkeszthetők a Organic Maps-ben.</string> | |||
<string name="editor_more_about_osm">További részletek az OpenStreetMap-ról</string> | |||
<string name="editor_operator">Üzemeltető</string> | |||
<string name="editor_category_unsuitable_title">Nem talál megfelelő kategóriát?</string> | |||
<string name="editor_category_unsuitable_text1">Az Organic Maps nem támogat minden kategóriát. Pl. városok, vasútállomások, utak, tavak vagy épületek nem adhatók hozzá. Kérjük, adjon hozzá ilyen funkciókat közvetlenül az osm.org oldalon keresztül (használja a szerkesztés gombot a felső sávban), vagy használjon egy speciális OSM-szerkesztő alkalmazást.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<string name="editor_category_unsuitable_text1">Az Organic Maps nem támogat minden kategóriát. Pl. városok, vasútállomások, utak, tavak vagy épületek nem adhatók hozzá. Kérjük, adjon hozzá ilyen funkciókat közvetlenül az osm.org oldalon keresztül (használja a szerkesztés gombot a felső sávban), vagy használjon egy speciális OSM-szerkesztő alkalmazást.</string> | |
<string name="editor_category_unsuitable_text1">Az Organic Maps sajnos nem támogat minden kategóriát. Pl. városok, vasútállomások, utak, tavak vagy épületek nem adhatók hozzá a térképhez. Kérjük, az ilyen típusú térképelemeket közvetlenül az osm.org oldalon keresztül adja hozzá (használja a szerkesztés gombot a felső sávban), vagy használjon egy speciális OSM-szerkesztő alkalmazást.</string> |
Yes, that's the best. Should we add that page to the current website or wait until the new website is ready? In terms of "categorie" vs "feature type" vs "object type" I don't have a strong opinion. But as you can't agree what is best I will keep "categories" for now, as it is currently used in OM. Text:Can't find a suitable category? Organic Maps allows to add simple point features only, that means no towns, roads, lakes, building outlines, etc. Please add such features directly to OpenStreetMap.org. You can find a detailed step by step guide at organicmaps.app/osm. Alternatively, you can also use OSM Notes (osm.org/wiki/Notes) for reports to the OSM Community. |
If you ask me, adding infos to the website alone wouldn't help, if there wasn't referring link to it in the app, because newbies would be left with no strings attached how to get further into contributing to the map. So if we pace on putting this to the website, we should link that page in the app as well, in the style of the original idea (described to learn more at the dedicated Organic Maps page). |
data/strings/strings.txt
Outdated
da = Kan du ikke finde en passende kategori? | ||
de = Keine passende Kategorie gefunden? | ||
el = Δεν μπορείτε να βρείτε την κατάλληλη κατηγορία; | ||
es = ¿No encuentras una categoría adecuada? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿No halla una categoría adecuada?
da = Alternativt kan du også bruge OSM Notes (osm.org/wiki/Notes) til rapporter til OSM-fællesskabet. | ||
de = Alternativ kannst du auch OSM Notes (osm.org/wiki/Notes) für Hinweise an die OSM Community verwenden. | ||
el = Εναλλακτικά, μπορείτε επίσης να χρησιμοποιήσετε το OSM Notes (osm.org/wiki/Notes) για αναφορές προς την κοινότητα του OSM. | ||
es = También puedes utilizar Notas OSM (osm.org/wiki/Notes) para informar a la Comunidad OSM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
es = También puede usar las notas (osm.org/wiki/Notes) para informar a la comunidad de OSM.
Please remove es-MX as unnecessary.
data/strings/strings.txt
Outdated
da = Organic Maps understøtter ikke alle kategorier. F.eks. kan byer, jernbanestationer, veje, søer eller bygninger ikke tilføjes. Tilføj venligst sådanne funktioner direkte via osm.org (brug Edit-knappen i øverste bjælke) eller brug en specialiseret OSM-redigeringsapp. | ||
de = Organic Maps unterstützt nicht alle Kategorien. So können z.B. Städte, Bahnhöfe, Straßen, Seen oder Gebäude nicht hinzugefügt werden. Bitte füge solche Orte direkt über osm.org hinzu (verwende die Schaltfläche Bearbeiten in der oberen Leiste) oder verwende eine spezielle OSM-Bearbeitungs-App. | ||
el = Οι οργανικοί χάρτες δεν υποστηρίζουν όλες τις κατηγορίες. Π.χ. δεν μπορούν να προστεθούν πόλεις, σιδηροδρομικοί σταθμοί, δρόμοι, λίμνες ή κτίρια. Παρακαλούμε προσθέστε τέτοια χαρακτηριστικά απευθείας μέσω του osm.org (χρησιμοποιήστε το κουμπί Επεξεργασία στην επάνω μπάρα) ή χρησιμοποιήστε μια εξειδικευμένη εφαρμογή επεξεργασίας OSM. | ||
es = Organic Maps no admite todas las categorías. Por ejemplo, no se pueden añadir ciudades, estaciones de ferrocarril, carreteras, lagos o edificios. Por favor, añade estas características directamente a través de osm.org (utiliza el botón Editar de la barra superior) o utiliza una aplicación de edición OSM especializada. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
es = Organic Maps no admite todas las categorías. Por ejemplo, no se pueden añadir ciudades, estaciones de ferrocarril, carreteras, lagos o edificios. Añada estos objetos directamente a través de osm.org (use el botón Editar de la barra superior) o utilice una aplicación especializada de edición de OSM.
Please remove es-MX as unnecessary.
fa = نقشه های ارگانیک از همه دسته ها پشتیبانی نمی کند. به عنوان مثال. شهرها، ایستگاه های راه آهن، جاده ها، دریاچه ها یا ساختمان ها را نمی توان اضافه کرد. لطفاً چنین ویژگی هایی را مستقیماً از طریق osm.org اضافه کنید (از دکمه ویرایش در نوار بالا استفاده کنید) یا از یک برنامه ویرایش تخصصی OSM استفاده کنید. | ||
fi = Organic Maps ei tue kaikkia luokkia. Esimerkiksi kaupunkeja, rautatieasemia, teitä, järviä tai rakennuksia ei voi lisätä. Lisää tällaiset ominaisuudet suoraan osm.org-sivuston kautta (käytä yläpalkin Muokkaa-painiketta) tai käytä erikoistunutta OSM-editointisovellusta. | ||
fr = Organic Maps ne prend pas en charge toutes les catégories. Par exemple, les villes, les gares, les routes, les lacs ou les bâtiments ne peuvent pas être ajoutés. Ajoute ces éléments directement via osm.org (utilise le bouton Modifier dans la barre supérieure) ou utilise une application d'édition OSM spécialisée. | ||
he = מפות אורגניות לא תומכות בכל הקטגוריות. לְמָשָׁל. לא ניתן להוסיף ערים, תחנות רכבת, כבישים, אגמים או מבנים. אנא הוסף תכונות כאלה ישירות דרך osm.org (השתמש בכפתור העריכה בסרגל העליון) או השתמש באפליקציית עריכה מיוחדת של OSM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
he = מפות אורגניות לא תומכות בכל הקטגוריות. לְמָשָׁל. לא ניתן להוסיף ערים, תחנות רכבת, כבישים, אגמים או מבנים. אנא הוסף תכונות כאלה ישירות דרך osm.org (השתמש בכפתור העריכה בסרגל העליון) או השתמש באפליקציית עריכה מיוחדת של OSM. | |
he = האפליקציה Organic Maps יכולה להוסיף רק נקודות, לא קווים או צורות. למשל, לא ניתן להוסיף כבישים, מבנים, ערים, תחנות רכבת, או אגמים. ניתן להוסיף תכונות כאלה ישירות דרך osm.org (השתמשו בכפתור העריכה בסרגל העליון באתר) או דרך אפליקציית עריכה ייעודית של OSM. |
I based this on the suggested rephrasing I posted above (which was based on pastk's suggestion) not the current commit. Here's a back-translation to English (via google translate):
The Organic Maps app can only add points, not lines or shapes. For example, you cannot add roads, buildings, cities, train stations, or lakes. Such features can be added directly through osm.org (use the edit button in the top bar of the site) or through a dedicated OSM editor application.
fa = همچنین میu200cتوانید از یادداشتu200cهای OSM (osm.org/wiki/Notes) برای گزارشu200cهایی به انجمن OSM استفاده کنید. | ||
fi = Vaihtoehtoisesti voit myös käyttää OSM Notesia (osm.org/wiki/Notes) OSM-yhteisölle tehtäviin raportteihin. | ||
fr = Tu peux aussi utiliser OSM Notes (osm.org/wiki/Notes) pour les rapports destinés à la communauté OSM. | ||
he = לחלופין, אתה יכול גם להשתמש ב-OSM Notes (osm.org/wiki/Notes) לדיווחים לקהילת OSM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit for he
:
he = לחלופין, אתה יכול גם להשתמש ב-OSM Notes (osm.org/wiki/Notes) לדיווחים לקהילת OSM. | |
he = לחלופין, ניתן להוסיף הערות למפה (osm.org/wiki/Notes) כדי לדווח לקהילת OSM. |
Q: Does Organic Maps allow users to add notes to the map? If not I don't see the value of this string, or at least it needs to be clarified that OM doesn't support this either.
Actually the original text from this PR used "features" also as in
Here its a mix of categories and features again. Let's pick just one then! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PT and PT-BR review.
data/strings/strings.txt
Outdated
pt = Não consegues encontrar uma categoria adequada? | ||
pt-BR = Você não consegue encontrar uma categoria adequada? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pt = Não consegues encontrar uma categoria adequada? | |
pt-BR = Você não consegue encontrar uma categoria adequada? | |
pt = Não encontra uma categoria adequada? | |
pt-BR = Você não encontra uma categoria adequada? |
data/strings/strings.txt
Outdated
pt = Os Mapas Orgânicos não suportam todas as categorias. Por exemplo, não podes adicionar cidades, estações de comboio, estradas, lagos ou edifícios. Por favor, adiciona essas características diretamente através de osm.org (usa o botão Editar na barra superior) ou usa uma aplicação de edição OSM especializada. | ||
pt-BR = O Organic Maps não é compatível com todas as categorias. Por exemplo, não é possível adicionar cidades, estações de trem, estradas, lagos ou edifícios. Adicione esses recursos diretamente em osm.org (use o botão Editar na barra superior) ou use um aplicativo de edição OSM especializado. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pt = Os Mapas Orgânicos não suportam todas as categorias. Por exemplo, não podes adicionar cidades, estações de comboio, estradas, lagos ou edifícios. Por favor, adiciona essas características diretamente através de osm.org (usa o botão Editar na barra superior) ou usa uma aplicação de edição OSM especializada. | |
pt-BR = O Organic Maps não é compatível com todas as categorias. Por exemplo, não é possível adicionar cidades, estações de trem, estradas, lagos ou edifícios. Adicione esses recursos diretamente em osm.org (use o botão Editar na barra superior) ou use um aplicativo de edição OSM especializado. | |
pt = O Organic Maps não suporta todas as categorias. Por exemplo, não é possível adicionar cidades, estações de comboio, estradas, lagos ou edifícios. Adicione esses elementos diretamente em osm.org (use o botão Editar na barra superior) ou use uma aplicação especializada em edição do OSM. | |
pt-BR = O Organic Maps não suporta todas as categorias. Por exemplo, não é possível adicionar cidades, estações de trem, estradas, lagos ou edifícios. Adicione esses elementos diretamente em osm.org (use o botão Editar na barra superior) ou use um aplicativo especializado em edição do OSM. |
Ok, so now the text is: Can't find a suitable feature type? Organic Maps allows to add simple point features only, that means no towns, roads, lakes, building outlines, etc. Please add such features directly to OpenStreetMap.org. You can find a detailed step by step guide at organicmaps.app/faq/editing/advanced-map-editing. Alternatively, you can also use OSM Notes for reports to the OSM Community. Visit osm.org/wiki/Notes for further details. |
Thanks! What about the more simplified version? Remember that people won't read longer texts, especially on mobile devices. Can't find a suitable object type? Towns, roads, lakes, buildings, and other objects can be added at OpenStreetMap.org or in other map editors. Check our guide or leave a note for the OSM community volunteers by long-tapping the place and selecting "Edit Place". The link should lead to a newbie-friendly FAQ page, which, in turn, should lead to a more advanced web page. |
First of all: Thanks for providing a full and written out alternative suggestion! But with that text it's not really clear that you need osm.org only for some things, but can edit most features within OM. I think its also better to visually separate osm.org editing and note, so we can later add an "Add a note" button below the second section. Let's stick with the text and not overcomplicate things. |
but it doesn't always work like that (e.g. can't do it on an "unknown place")..
Sounds good! Just please make sure its used consistently so |
@organicmaps/translations Thanks for the translation improvements of "Can't find a suitable category". Can you please take a look at the new editor_category_unsuitable_text as well. |
nl is ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Pixel 6 - Android 14
I updated the translations, so this is ready for merge now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the translations are bad because it's a whole paragraph (with embedded links, no less) and needs human review. @organicmaps/translations
@@ -504,6 +504,8 @@ | |||
<string name="editor_detailed_description">Los cambios que ha sugerido se enviarán a la comunidad de OpenStreetMap. Describa los detalles que no pueden editarse en Organic Maps.</string> | |||
<string name="editor_more_about_osm">Más acerca de OpenStreetMap</string> | |||
<string name="editor_operator">Operador</string> | |||
<string name="editor_category_unsuitable_title">¿No halla una categoría adecuada?</string> | |||
<string name="editor_category_unsuitable_text">Organic Maps sólo permite añadir categorías de puntos simples, es decir, no ciudades, carreteras, lagos, contornos de edificios, etc. Por favor, añade dichas categorías directamente a <a href="https://www.openstreetmap.org">OpenStreetMap.org</a>. Consulta nuestra <a href="https://organicmaps.app/faq/editing/advanced-map-editing">guía</a> para obtener instrucciones detalladas paso a paso.</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefiero:
Organic Maps permite añadir únicamente categorías de puntos sencillos, es decir, no ciudades, carreteras, lagos, contornos de edificios, etc. Por favor, añade dichas categorías directamente a OpenStreetMap.org. Consulta nuestra guía para obtener instrucciones detalladas paso a paso.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muralito: Your suggestion looks good, but we have to use the formal language version:
Organic Maps permite añadir únicamente categorías de puntos sencillos, es decir, no ciudades, carreteras, lagos, contornos de edificios, etc. Por favor, añada dichas categorías directamente a OpenStreetMap.org. Consulte nuestra guía para obtener instrucciones detalladas paso a paso.
@biodranik is it good enough to merge? |
Updated he and es strings |
android/app/src/main/java/app/organicmaps/editor/FeatureCategoryFragment.java
Show resolved
Hide resolved
@map-per could you please include the last translation changes and we'll merge to take it into the release? |
Signed-off-by: map-per <map-per@gmx.de>
Signed-off-by: map-per <map-per@gmx.de>
👍 Updated the translations and used a local variable for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @kirylkaveryn can you please add a similar hint with the same strings to iOS?
And many thanks to everyone who participated, community is the power! 🚀 |
closes #6733
Added an explanation, that one can not find a category for everything in the list. The text guides users towards editing with other editors or using OSM Notes. (As soon as adding OSM notes with OM (#266) is possible we can link to that feature from here)
The intention behind the text is to prevent users from adding similar categories instead of the right ones. E.g.
drinking_water
instead of awastewater_plant
orattraction
for everything (see #6733).Moreover this avoids confusion, why e.g. address or building is not in the list.
The text is similar to the one suggested by @pastk in #6733 (comment)
Details