Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][editor] 'No suitable category' info #7748

Merged
merged 2 commits into from
May 2, 2024

Conversation

map-per
Copy link
Member

@map-per map-per commented Mar 30, 2024

closes #6733

Added an explanation, that one can not find a category for everything in the list. The text guides users towards editing with other editors or using OSM Notes. (As soon as adding OSM notes with OM (#266) is possible we can link to that feature from here)

The intention behind the text is to prevent users from adding similar categories instead of the right ones. E.g. drinking_water instead of a wastewater_plant or attraction for everything (see #6733).
Moreover this avoids confusion, why e.g. address or building is not in the list.

The text is similar to the one suggested by @pastk in #6733 (comment)

Screenshot_2024-03-30-19-04-08-596_app organicmaps debug Screenshot_2024-03-30-19-05-19-342_app organicmaps debug

Screenshot_2024-03-30-19-04-16-307_app organicmaps debug

Details

  • The information text is always shown below the list, so users see it after parsing the list
  • FeatureCategoryFragment needed to be changed to keep the current behaviour of jumping to the top of the list when the search text is changed
  • The textblock has a maxWidth to stay compact on big screens or in landscape mode

@RedAuburn
Copy link
Sponsor Member

nice! it might be good if there was a button to add a note from that screen too :)

@pastk
Copy link
Contributor

pastk commented Mar 30, 2024

Isn't the "category" word confusing in this context?
Maybe better to use e.g. "feature type"? (e.g. iD uses it)

@biodranik
Copy link
Member

The "category" wording comes from the search tab. Using a different word requires replacing it everywhere consistently.

Most users do not know what "lines, areas, tags, features, OSM" mean, and won't understand the text. Only those who are already familiar with OSM will read it properly.

@map-per
Copy link
Member Author

map-per commented Apr 1, 2024

Isn't the "category" word confusing in this context?
Maybe better to use e.g. "feature type"? (e.g. iD uses it)

I think "category" is better here for users who don't know the more OSM specific / more technical term "feature type".

Most users do not know what "lines, areas, tags, features, OSM" mean, and won't understand the text. Only those who are already familiar with OSM will read it properly.

That's right. Let's use this text:

"Organic Maps does not support all categories. E.g. cities, railway stations, roads, lakes, or buildings can not be added. Please add such features directly via osm.org (use the Edit button in the top bar) or use a specialized OSM editing app."

@map-per
Copy link
Member Author

map-per commented Apr 2, 2024

I updated the text and added translations

@map-per map-per requested a review from a team April 2, 2024 11:33
Copy link
Contributor

@jimcarst jimcarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for nl

@biodranik
Copy link
Member

Should we recommend other OSM editors here and provide links to them?

@muralito
Copy link
Contributor

muralito commented Apr 2, 2024

Should we recommend other OSM editors here and provide links to them?

What about linking OSM Wiki https://wiki.openstreetmap.org/wiki/Editors ?

@pastk
Copy link
Contributor

pastk commented Apr 2, 2024

The "category" wording comes from the search tab. Using a different word requires replacing it everywhere consistently.

Search categories are different things. E.g. "where to eat" searches across multiple feature types.
upd: i.e. all feature types are divided into categories - like this it makes sense

I think this is the only place the "category" word is used in the editor (so easy to change):
image

I think "category" is better here for users who don't know the more OSM specific / more technical term "feature type".

IMHO "feature type" is more obvious / understandable.
E.g.

"Organic Maps does not support all categories.

Categories of what? Its confusing without further refinement.
upd: and there is absolutely no hint/reference to what is a "category" on this search / selection screen.


[editor_category_unsuitable_text1]
tags = android
en = Organic Maps does not support all categories. E.g. cities, railway stations, roads, lakes, or buildings can not be added. Please add such features directly via osm.org (use the Edit button in the top bar) or use a specialized OSM editing app.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe first sentence like
Organic Maps allows to add simple point features only, that means no towns, roads, lakes, building outlines, etc.
?

Please add such features directly via osm.org (use the Edit button in the top bar) or use

Here I read it like there is an Edit button in OM's top bar that'll get me to the right place in osm.org... Maybe drop the (use the Edit button in the top bar) completely? or rephrase

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"objects" then is clearer for newbies than a highly specific term "features".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"objects", "map objects", "object types", etc. should be good indeed

Copy link
Contributor

@NeatNit NeatNit Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second the suggestion for the first sentence, clarifying that only points are supported. Here's my edit to the suggestion:

Suggested change
en = Organic Maps does not support all categories. E.g. cities, railway stations, roads, lakes, or buildings can not be added. Please add such features directly via osm.org (use the Edit button in the top bar) or use a specialized OSM editing app.
en = Organic Maps can only add point features, not lines or shapes. This means you cannot add roads, buildings, cities, railway stations, or lakes, among other things. Please add such features directly via osm.org (use the Edit button in the top bar of the website) or use a specialized OSM editing app.

I've also made roads and buildings first in the list of examples (they get the point across better than cities IMO) and clarified the top bar as noted.

Edit: if you don't like features, it can just be: "Organic Maps can only add points, not lines or shapes."

@Zverik
Copy link
Contributor

Zverik commented Apr 3, 2024

First, I like the idea very much. The panel stands out, and serves a good introduction to where the data goes.

What'd I improve is shifting the focus from the website (we're on a phone remember) to apps. It should mention 2-3 most prominent mapping alternatives on the platform, different for iOS and Android: StreetComplete, Vespucci, Go Map, Every Door.

But that might make the panel too big, so we might consider making a dedicated page, and here just put a link. E.g. "To add or edit features of all types consider installing a dedicated app...".

Also, you can add notes with Organic Maps, so it should be a button, not a link.

Comment on lines 491 to 493
<string name="editor_category_unsuitable_title">Nu găsiți o categorie potrivită?</string>
<string name="editor_category_unsuitable_text1">Organic Maps nu acceptă toate categoriile. De exemplu, nu pot fi adăugate orașe, gări, drumuri, lacuri sau clădiri. Vă rugăm să adăugați astfel de caracteristici direct prin osm.org (utilizați butonul Edit din bara de sus) sau să folosiți o aplicație specializată de editare OSM.</string>
<string name="editor_category_unsuitable_text2">Alternativ, puteți utiliza și OSM Notes (osm.org/wiki/Notes) pentru rapoarte către comunitatea OSM.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ro translation looks good.

@pastk
Copy link
Contributor

pastk commented Apr 3, 2024

Re "categories" vs "feature types" vs "object types".

Using "objects" or "features" sounds good to me.

However when people will eventually proceed to osm.org (and we want them to do it) for wiki, beginner guide, editor, support chats, etc. they will have to re-learn to "map features" again.

So I'd rather start with the "osm standard term" "features" right away, IMHO its very understandable given the context and eventually there will be less confusion created by different terms usage.

My suggestion:

Can't find a suitable feature type?

Organic Maps allows to add simple point features only, that means no towns, roads, lakes, building outlines, etc. Please add such features directly to OpenStreetMap.org (there is Edit button on the web site) or use a specialized OSM editing app like Every Door, StreetComplete or Vespucci.

(as OM doesn't support leaving standalone Notes yet then its better to drop this part IMO)

The "Category" caption ([editor_edit_place_category_title]) on the editing screen should be replaced with "Map Feature Type" or just "Feature Type".

And its better to replace the "Search" text inside the search field with a hint like e.g. pharmacy or bus stop.

@biodranik
Copy link
Member

If a user doesn't uninstall OM and visit OSM, then he/she will be able to learn anything.

Which of the definitions below fits the context?
выява

@pastk
Copy link
Contributor

pastk commented Apr 3, 2024

If there is a concern that a "feature" is ambiguous / not specific enough then just use a "map feature"?
My understanding is that its a pretty standard term in mapping.

@map-per
Copy link
Member Author

map-per commented Apr 3, 2024

What'd I improve is shifting the focus from the website (we're on a phone remember) to apps. It should mention 2-3 most prominent mapping alternatives on the platform, different for iOS and Android: StreetComplete, Vespucci, Go Map, Every Door.

Good catch with the phone, ID is unusable on a phone (you have to rotate your phone all the time to access buttons). But I would rather suggest users to use ID on a PC as all Android apps can either not edit everything (StreetComplete, Every Door, OSM Go!) or are very complicated to use (Vespucci, OSM Go!). (Go Map is ios only)

We could also add a link to the Beginners Guide in the OSM Wiki

@biodranik
Copy link
Member

A detailed page on OM website may be better than everything else, because:

  • OSM "Beginners guide" doesn't immediately show apps to install (and it may be too complex for grandparents willing to add some object on a map)
  • The concept of "OSM is not OM" can be properly introduced
  • We can use images
  • We can list top editors and mention their difference
  • We can mention ID too with a comment "use it on the desktop".

Copy link
Contributor

@d4f5409d d4f5409d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇭🇺❌

@@ -490,6 +490,9 @@
<string name="editor_detailed_description">Javasolt változtatásait elküldjük az OpenStreetMap közösségnek. Írja le a további információkat, amelyek nem szerkeszthetők a Organic Maps-ben.</string>
<string name="editor_more_about_osm">További részletek az OpenStreetMap-ról</string>
<string name="editor_operator">Üzemeltető</string>
<string name="editor_category_unsuitable_title">Nem talál megfelelő kategóriát?</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="editor_category_unsuitable_title">Nem talál megfelelő kategóriát?</string>
<string name="editor_category_unsuitable_title">Nem találja a megfelelő kategóriát?</string>

@@ -490,6 +490,9 @@
<string name="editor_detailed_description">Javasolt változtatásait elküldjük az OpenStreetMap közösségnek. Írja le a további információkat, amelyek nem szerkeszthetők a Organic Maps-ben.</string>
<string name="editor_more_about_osm">További részletek az OpenStreetMap-ról</string>
<string name="editor_operator">Üzemeltető</string>
<string name="editor_category_unsuitable_title">Nem talál megfelelő kategóriát?</string>
<string name="editor_category_unsuitable_text1">Az Organic Maps nem támogat minden kategóriát. Pl. városok, vasútállomások, utak, tavak vagy épületek nem adhatók hozzá. Kérjük, adjon hozzá ilyen funkciókat közvetlenül az osm.org oldalon keresztül (használja a szerkesztés gombot a felső sávban), vagy használjon egy speciális OSM-szerkesztő alkalmazást.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<string name="editor_category_unsuitable_text1">Az Organic Maps nem támogat minden kategóriát. Pl. városok, vasútállomások, utak, tavak vagy épületek nem adhatók hozzá. Kérjük, adjon hozzá ilyen funkciókat közvetlenül az osm.org oldalon keresztül (használja a szerkesztés gombot a felső sávban), vagy használjon egy speciális OSM-szerkesztő alkalmazást.</string>
<string name="editor_category_unsuitable_text1">Az Organic Maps sajnos nem támogat minden kategóriát. Pl. városok, vasútállomások, utak, tavak vagy épületek nem adhatók hozzá a térképhez. Kérjük, az ilyen típusú térképelemeket közvetlenül az osm.org oldalon keresztül adja hozzá (használja a szerkesztés gombot a felső sávban), vagy használjon egy speciális OSM-szerkesztő alkalmazást.</string>

@map-per
Copy link
Member Author

map-per commented Apr 5, 2024

A detailed page on OM website may be better than everything else, because:

Yes, that's the best. Should we add that page to the current website or wait until the new website is ready?

In terms of "categorie" vs "feature type" vs "object type" I don't have a strong opinion. But as you can't agree what is best I will keep "categories" for now, as it is currently used in OM.

Text:

Can't find a suitable category?

Organic Maps allows to add simple point features only, that means no towns, roads, lakes, building outlines, etc. Please add such features directly to OpenStreetMap.org. You can find a detailed step by step guide at organicmaps.app/osm.

Alternatively, you can also use OSM Notes (osm.org/wiki/Notes) for reports to the OSM Community.

@d4f5409d
Copy link
Contributor

d4f5409d commented Apr 5, 2024

If you ask me, adding infos to the website alone wouldn't help, if there wasn't referring link to it in the app, because newbies would be left with no strings attached how to get further into contributing to the map. So if we pace on putting this to the website, we should link that page in the app as well, in the style of the original idea (described to learn more at the dedicated Organic Maps page).
This way I think, we could reduce both the amount of text in the app so the end user wouldn't get overwhelmed if they are already experienced, and everything could go as expected in order.

da = Kan du ikke finde en passende kategori?
de = Keine passende Kategorie gefunden?
el = Δεν μπορείτε να βρείτε την κατάλληλη κατηγορία;
es = ¿No encuentras una categoría adecuada?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿No halla una categoría adecuada?

da = Alternativt kan du også bruge OSM Notes (osm.org/wiki/Notes) til rapporter til OSM-fællesskabet.
de = Alternativ kannst du auch OSM Notes (osm.org/wiki/Notes) für Hinweise an die OSM Community verwenden.
el = Εναλλακτικά, μπορείτε επίσης να χρησιμοποιήσετε το OSM Notes (osm.org/wiki/Notes) για αναφορές προς την κοινότητα του OSM.
es = También puedes utilizar Notas OSM (osm.org/wiki/Notes) para informar a la Comunidad OSM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es = También puede usar las notas (osm.org/wiki/Notes) para informar a la comunidad de OSM.

Please remove es-MX as unnecessary.

da = Organic Maps understøtter ikke alle kategorier. F.eks. kan byer, jernbanestationer, veje, søer eller bygninger ikke tilføjes. Tilføj venligst sådanne funktioner direkte via osm.org (brug Edit-knappen i øverste bjælke) eller brug en specialiseret OSM-redigeringsapp.
de = Organic Maps unterstützt nicht alle Kategorien. So können z.B. Städte, Bahnhöfe, Straßen, Seen oder Gebäude nicht hinzugefügt werden. Bitte füge solche Orte direkt über osm.org hinzu (verwende die Schaltfläche Bearbeiten in der oberen Leiste) oder verwende eine spezielle OSM-Bearbeitungs-App.
el = Οι οργανικοί χάρτες δεν υποστηρίζουν όλες τις κατηγορίες. Π.χ. δεν μπορούν να προστεθούν πόλεις, σιδηροδρομικοί σταθμοί, δρόμοι, λίμνες ή κτίρια. Παρακαλούμε προσθέστε τέτοια χαρακτηριστικά απευθείας μέσω του osm.org (χρησιμοποιήστε το κουμπί Επεξεργασία στην επάνω μπάρα) ή χρησιμοποιήστε μια εξειδικευμένη εφαρμογή επεξεργασίας OSM.
es = Organic Maps no admite todas las categorías. Por ejemplo, no se pueden añadir ciudades, estaciones de ferrocarril, carreteras, lagos o edificios. Por favor, añade estas características directamente a través de osm.org (utiliza el botón Editar de la barra superior) o utiliza una aplicación de edición OSM especializada.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es = Organic Maps no admite todas las categorías. Por ejemplo, no se pueden añadir ciudades, estaciones de ferrocarril, carreteras, lagos o edificios. Añada estos objetos directamente a través de osm.org (use el botón Editar de la barra superior) o utilice una aplicación especializada de edición de OSM.

Please remove es-MX as unnecessary.

fa = نقشه های ارگانیک از همه دسته ها پشتیبانی نمی کند. به عنوان مثال. شهرها، ایستگاه های راه آهن، جاده ها، دریاچه ها یا ساختمان ها را نمی توان اضافه کرد. لطفاً چنین ویژگی هایی را مستقیماً از طریق osm.org اضافه کنید (از دکمه ویرایش در نوار بالا استفاده کنید) یا از یک برنامه ویرایش تخصصی OSM استفاده کنید.
fi = Organic Maps ei tue kaikkia luokkia. Esimerkiksi kaupunkeja, rautatieasemia, teitä, järviä tai rakennuksia ei voi lisätä. Lisää tällaiset ominaisuudet suoraan osm.org-sivuston kautta (käytä yläpalkin Muokkaa-painiketta) tai käytä erikoistunutta OSM-editointisovellusta.
fr = Organic Maps ne prend pas en charge toutes les catégories. Par exemple, les villes, les gares, les routes, les lacs ou les bâtiments ne peuvent pas être ajoutés. Ajoute ces éléments directement via osm.org (utilise le bouton Modifier dans la barre supérieure) ou utilise une application d'édition OSM spécialisée.
he = מפות אורגניות לא תומכות בכל הקטגוריות. לְמָשָׁל. לא ניתן להוסיף ערים, תחנות רכבת, כבישים, אגמים או מבנים. אנא הוסף תכונות כאלה ישירות דרך osm.org (השתמש בכפתור העריכה בסרגל העליון) או השתמש באפליקציית עריכה מיוחדת של OSM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
he = מפות אורגניות לא תומכות בכל הקטגוריות. לְמָשָׁל. לא ניתן להוסיף ערים, תחנות רכבת, כבישים, אגמים או מבנים. אנא הוסף תכונות כאלה ישירות דרך osm.org (השתמש בכפתור העריכה בסרגל העליון) או השתמש באפליקציית עריכה מיוחדת של OSM.
he = האפליקציה Organic Maps יכולה להוסיף רק נקודות, לא קווים או צורות. למשל, לא ניתן להוסיף כבישים, מבנים, ערים, תחנות רכבת, או אגמים. ניתן להוסיף תכונות כאלה ישירות דרך osm.org (השתמשו בכפתור העריכה בסרגל העליון באתר) או דרך אפליקציית עריכה ייעודית של OSM.

I based this on the suggested rephrasing I posted above (which was based on pastk's suggestion) not the current commit. Here's a back-translation to English (via google translate):

The Organic Maps app can only add points, not lines or shapes. For example, you cannot add roads, buildings, cities, train stations, or lakes. Such features can be added directly through osm.org (use the edit button in the top bar of the site) or through a dedicated OSM editor application.

fa = همچنین میu200cتوانید از یادداشتu200cهای OSM (osm.org/wiki/Notes) برای گزارشu200cهایی به انجمن OSM استفاده کنید.
fi = Vaihtoehtoisesti voit myös käyttää OSM Notesia (osm.org/wiki/Notes) OSM-yhteisölle tehtäviin raportteihin.
fr = Tu peux aussi utiliser OSM Notes (osm.org/wiki/Notes) pour les rapports destinés à la communauté OSM.
he = לחלופין, אתה יכול גם להשתמש ב-OSM Notes (osm.org/wiki/Notes) לדיווחים לקהילת OSM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit for he:

Suggested change
he = לחלופין, אתה יכול גם להשתמש ב-OSM Notes (osm.org/wiki/Notes) לדיווחים לקהילת OSM.
he = לחלופין, ניתן להוסיף הערות למפה (osm.org/wiki/Notes) כדי לדווח לקהילת OSM.

Q: Does Organic Maps allow users to add notes to the map? If not I don't see the value of this string, or at least it needs to be clarified that OM doesn't support this either.

@pastk
Copy link
Contributor

pastk commented Apr 6, 2024

In terms of "categorie" vs "feature type" vs "object type" I don't have a strong opinion. But as you can't agree what is best I will keep "categories" for now, as it is currently used in OM.

Actually the original text from this PR used "features" also as in Please add such features directly via ... :) Its just comes naturally, isn't it?

Text:

Can't find a suitable category?

Organic Maps allows to add simple point features only, that means no towns, roads, lakes, building outlines, etc. Please add such features directly to OpenStreetMap.org. You can find a detailed step by step guide at organicmaps.app/osm.

Alternatively, you can also use OSM Notes (osm.org/wiki/Notes) for reports to the OSM Community.

Here its a mix of categories and features again. Let's pick just one then!

Copy link
Contributor

@matheusgomesms matheusgomesms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PT and PT-BR review.

Comment on lines 16416 to 16417
pt = Não consegues encontrar uma categoria adequada?
pt-BR = Você não consegue encontrar uma categoria adequada?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pt = Não consegues encontrar uma categoria adequada?
pt-BR = Você não consegue encontrar uma categoria adequada?
pt = Não encontra uma categoria adequada?
pt-BR = Você não encontra uma categoria adequada?

Comment on lines 16462 to 16463
pt = Os Mapas Orgânicos não suportam todas as categorias. Por exemplo, não podes adicionar cidades, estações de comboio, estradas, lagos ou edifícios. Por favor, adiciona essas características diretamente através de osm.org (usa o botão Editar na barra superior) ou usa uma aplicação de edição OSM especializada.
pt-BR = O Organic Maps não é compatível com todas as categorias. Por exemplo, não é possível adicionar cidades, estações de trem, estradas, lagos ou edifícios. Adicione esses recursos diretamente em osm.org (use o botão Editar na barra superior) ou use um aplicativo de edição OSM especializado.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pt = Os Mapas Orgânicos não suportam todas as categorias. Por exemplo, não podes adicionar cidades, estações de comboio, estradas, lagos ou edifícios. Por favor, adiciona essas características diretamente através de osm.org (usa o botão Editar na barra superior) ou usa uma aplicação de edição OSM especializada.
pt-BR = O Organic Maps não é compatível com todas as categorias. Por exemplo, não é possível adicionar cidades, estações de trem, estradas, lagos ou edifícios. Adicione esses recursos diretamente em osm.org (use o botão Editar na barra superior) ou use um aplicativo de edição OSM especializado.
pt = O Organic Maps não suporta todas as categorias. Por exemplo, não é possível adicionar cidades, estações de comboio, estradas, lagos ou edifícios. Adicione esses elementos diretamente em osm.org (use o botão Editar na barra superior) ou use uma aplicação especializada em edição do OSM.
pt-BR = O Organic Maps não suporta todas as categorias. Por exemplo, não é possível adicionar cidades, estações de trem, estradas, lagos ou edifícios. Adicione esses elementos diretamente em osm.org (use o botão Editar na barra superior) ou use um aplicativo especializado em edição do OSM.

@map-per
Copy link
Member Author

map-per commented Apr 12, 2024

Ok, so now the text is:

Can't find a suitable feature type?

Organic Maps allows to add simple point features only, that means no towns, roads, lakes, building outlines, etc. Please add such features directly to OpenStreetMap.org. You can find a detailed step by step guide at organicmaps.app/faq/editing/advanced-map-editing.

Alternatively, you can also use OSM Notes for reports to the OSM Community. Visit osm.org/wiki/Notes for further details.

@biodranik
Copy link
Member

biodranik commented Apr 12, 2024

Thanks! What about the more simplified version? Remember that people won't read longer texts, especially on mobile devices.


Can't find a suitable object type?

Towns, roads, lakes, buildings, and other objects can be added at OpenStreetMap.org or in other map editors. Check our guide or leave a note for the OSM community volunteers by long-tapping the place and selecting "Edit Place".


The link should lead to a newbie-friendly FAQ page, which, in turn, should lead to a more advanced web page.

@map-per
Copy link
Member Author

map-per commented Apr 12, 2024

First of all: Thanks for providing a full and written out alternative suggestion!

But with that text it's not really clear that you need osm.org only for some things, but can edit most features within OM.
And telling people who want to report that something is missing to "long-tapping the place" is rather confusing.

I think its also better to visually separate osm.org editing and note, so we can later add an "Add a note" button below the second section.

Let's stick with the text and not overcomplicate things.

@pastk
Copy link
Contributor

pastk commented Apr 12, 2024

or leave a note for the OSM community volunteers by long-tapping the place and selecting "Edit Place".

but it doesn't always work like that (e.g. can't do it on an "unknown place")..
I think first an independent osm note adding functionality should be improved and then we'll be able to add a direct button/link.

Ok, so now the text is:

Sounds good!
For me either version of the wording and terms used (category/feature/object - up to you @map-per ) is fine and is a good improvement already.

Just please make sure its used consistently so [editor_edit_place_category_title] in strings.txt might need to be changed.

@map-per
Copy link
Member Author

map-per commented Apr 21, 2024

I removed the paragraph about OSM Notes, shortened the URL text, and updated the text.

Todo:

  • Include translation reviews for "Can't find a suitable category"

@map-per
Copy link
Member Author

map-per commented Apr 23, 2024

@organicmaps/translations

Thanks for the translation improvements of "Can't find a suitable category".

Can you please take a look at the new editor_category_unsuitable_text as well.

@jimcarst
Copy link
Contributor

nl is ok

Copy link
Member

@Jean-BaptisteC Jean-BaptisteC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Pixel 6 - Android 14

@map-per
Copy link
Member Author

map-per commented Apr 25, 2024

I updated the translations, so this is ready for merge now

Copy link
Contributor

@NeatNit NeatNit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the translations are bad because it's a whole paragraph (with embedded links, no less) and needs human review. @organicmaps/translations

data/strings/strings.txt Show resolved Hide resolved
@@ -504,6 +504,8 @@
<string name="editor_detailed_description">Los cambios que ha sugerido se enviarán a la comunidad de OpenStreetMap. Describa los detalles que no pueden editarse en Organic Maps.</string>
<string name="editor_more_about_osm">Más acerca de OpenStreetMap</string>
<string name="editor_operator">Operador</string>
<string name="editor_category_unsuitable_title">¿No halla una categoría adecuada?</string>
<string name="editor_category_unsuitable_text">Organic Maps sólo permite añadir categorías de puntos simples, es decir, no ciudades, carreteras, lagos, contornos de edificios, etc. Por favor, añade dichas categorías directamente a <a href="https://www.openstreetmap.org">OpenStreetMap.org</a>. Consulta nuestra <a href="https://organicmaps.app/faq/editing/advanced-map-editing">guía</a> para obtener instrucciones detalladas paso a paso.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefiero:

Organic Maps permite añadir únicamente categorías de puntos sencillos, es decir, no ciudades, carreteras, lagos, contornos de edificios, etc. Por favor, añade dichas categorías directamente a OpenStreetMap.org. Consulta nuestra guía para obtener instrucciones detalladas paso a paso.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muralito: Your suggestion looks good, but we have to use the formal language version:

Organic Maps permite añadir únicamente categorías de puntos sencillos, es decir, no ciudades, carreteras, lagos, contornos de edificios, etc. Por favor, añada dichas categorías directamente a OpenStreetMap.org. Consulte nuestra guía para obtener instrucciones detalladas paso a paso.

@pastk
Copy link
Contributor

pastk commented Apr 26, 2024

@biodranik is it good enough to merge?

@map-per
Copy link
Member Author

map-per commented Apr 26, 2024

Updated he and es strings

data/strings/strings.txt Show resolved Hide resolved
data/strings/strings.txt Show resolved Hide resolved
data/strings/strings.txt Show resolved Hide resolved
data/strings/strings.txt Show resolved Hide resolved
data/strings/strings.txt Show resolved Hide resolved
data/strings/strings.txt Show resolved Hide resolved
@biodranik biodranik added this to the Needs alpha/beta testing milestone Apr 28, 2024
@pastk
Copy link
Contributor

pastk commented May 2, 2024

@map-per could you please include the last translation changes and we'll merge to take it into the release?

map-per added 2 commits May 2, 2024 21:52
Signed-off-by: map-per <map-per@gmx.de>
Signed-off-by: map-per <map-per@gmx.de>
@map-per
Copy link
Member Author

map-per commented May 2, 2024

👍 Updated the translations and used a local variable for categoryUnsuitableText

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @kirylkaveryn can you please add a similar hint with the same strings to iOS?

@biodranik
Copy link
Member

And many thanks to everyone who participated, community is the power! 🚀

@biodranik biodranik merged commit 1defafb into organicmaps:master May 2, 2024
7 checks passed
@map-per map-per deleted the category branch May 3, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

People add to OSM the most "related" feature type / tag if the one they look for is missing