-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add natural=scree and =shingle; better bare_rock color #7761
Conversation
The Hebrew transations are definitely wrong. "Shingle" was translated into "file a complaint" somehow :D. For the sake of all translators, here's precise explanations for what each type is:
I assume this is this https://en.wikipedia.org/wiki/Shingle_beach (I've never heard of this term before I looked this up, and almost translated it to roofing tiles) - essentially loose pebbles. is this different from
https://en.wikipedia.org/wiki/Scree - if my reading is right, this is a name for the stuff found at the base of a cliff. The Wikipedia page is translated to many languages, if yours is available you should just use the title from there (that's what I'll do) Edit: and potentially more languages listed here https://www.wikidata.org/wiki/Q1133195 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as mentioned in previous comment, consider whether [type.natural.shingle] is distinct from [type.natural.beach.gravel] - and if so, please clarify the difference.
data/strings/types_strings.txt
Outdated
fa = گزارش | ||
fi = Pebbles | ||
fr = Galets | ||
he = להגיש תלונה |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two options:
literally "stones":
he = להגיש תלונה | |
he = אבנים |
or
literally "gravel":
he = להגיש תלונה | |
he = חצץ |
Maybe there's a more accurate technical term that I'm not familiar with. Looking this up is really hard because the English word "shingle" has too many meanings. The few answers I did find just say to use the word for gravel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gravel could be sharp, shingle/pebbles is supposed to be rounded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK there is no word for that in Hebrew. My intuition is to call it אבנים (stones), but I don't know if that's just me or something most people would agree with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps אבנים חלקות (smooth stones), but that sort of implies they're slippery which is also not the case...
Unfortunately Deepl (or Google?) return such strings instead of the actual translation sometimes. @biodranik is it detectable, so that could be automatically retried or at least removed from the results?
Good point! Looks like practically there is not much difference. Maybe a dried riverbed could be laid with shingle, but its not a beach. https://wiki.openstreetmap.org/wiki/Tag:natural%3Dshingle
https://wiki.openstreetmap.org/wiki/Tag:natural%3Dscree Scree consists of moving sharp stones and is usually on a (steep) slope. Makes it hard and dangerous to climb or descend. |
a891bd0
to
18fef5e
Compare
I've added comments to the |
eu = harri koskor |
18fef5e
to
c097284
Compare
Included latest translation suggestions. |
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
c097284
to
b73cf4a
Compare
Just tested via Firebase and looks good. Thanks! ✌️ We should start thinking how to render different types of beaches. Maybe changing them once user zooms in, but that's for another Issue. |
Mmm.. It shouldn't be on Firebase, impossible :) It was just merged :) |
bare_rock was lighter than the background and barely distinguishable.
I made it darker with a brownish tint.
scree and shingle will be darker grey.