Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add natural=scree and =shingle; better bare_rock color #7761

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

pastk
Copy link
Contributor

@pastk pastk commented Mar 31, 2024

bare_rock was lighter than the background and barely distinguishable.
I made it darker with a brownish tint.
scree and shingle will be darker grey.

bare_rock-scree

@pastk pastk requested review from vng and a team March 31, 2024 19:32
@pastk pastk requested a review from a team as a code owner March 31, 2024 19:32
@pastk pastk mentioned this pull request Mar 31, 2024
16 tasks
@pastk pastk requested a review from a team March 31, 2024 21:05
@NeatNit
Copy link
Contributor

NeatNit commented Mar 31, 2024

The Hebrew transations are definitely wrong. "Shingle" was translated into "file a complaint" somehow :D.

For the sake of all translators, here's precise explanations for what each type is:


  [type.natural.shingle]
    en = Shingle

I assume this is this https://en.wikipedia.org/wiki/Shingle_beach (I've never heard of this term before I looked this up, and almost translated it to roofing tiles) - essentially loose pebbles.

is this different from [type.natural.beach.gravel] en = Gravel Beach?

image


  [type.natural.scree]
    en = Scree

https://en.wikipedia.org/wiki/Scree - if my reading is right, this is a name for the stuff found at the base of a cliff. The Wikipedia page is translated to many languages, if yours is available you should just use the title from there (that's what I'll do)

Edit: and potentially more languages listed here https://www.wikidata.org/wiki/Q1133195

Copy link
Contributor

@NeatNit NeatNit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned in previous comment, consider whether [type.natural.shingle] is distinct from [type.natural.beach.gravel] - and if so, please clarify the difference.

fa = گزارش
fi = Pebbles
fr = Galets
he = להגיש תלונה
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two options:

literally "stones":

Suggested change
he = להגיש תלונה
he = אבנים

or

literally "gravel":

Suggested change
he = להגיש תלונה
he = חצץ

Maybe there's a more accurate technical term that I'm not familiar with. Looking this up is really hard because the English word "shingle" has too many meanings. The few answers I did find just say to use the word for gravel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gravel could be sharp, shingle/pebbles is supposed to be rounded.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK there is no word for that in Hebrew. My intuition is to call it אבנים (stones), but I don't know if that's just me or something most people would agree with.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps אבנים חלקות (smooth stones), but that sort of implies they're slippery which is also not the case...

data/strings/types_strings.txt Outdated Show resolved Hide resolved
@pastk
Copy link
Contributor Author

pastk commented Apr 1, 2024

The Hebrew transations are definitely wrong. "Shingle" was translated into "file a complaint" somehow :D.

Unfortunately Deepl (or Google?) return such strings instead of the actual translation sometimes. @biodranik is it detectable, so that could be automatically retried or at least removed from the results?

is this different from [type.natural.beach.gravel] en = Gravel Beach?

Good point! Looks like practically there is not much difference. Maybe a dried riverbed could be laid with shingle, but its not a beach.

https://wiki.openstreetmap.org/wiki/Tag:natural%3Dshingle

https://en.wikipedia.org/wiki/Scree - if my reading is right, this is a name for the stuff found at the base of a cliff. The Wikipedia page is translated to many languages, if yours is available you should just use the title from there (that's what I'll do)

https://wiki.openstreetmap.org/wiki/Tag:natural%3Dscree

Scree consists of moving sharp stones and is usually on a (steep) slope. Makes it hard and dangerous to climb or descend.

@pastk pastk force-pushed the pastk-classif-add-scree-shingle branch from a891bd0 to 18fef5e Compare April 1, 2024 09:00
@pastk
Copy link
Contributor Author

pastk commented Apr 1, 2024

I've added comments to the types_strings.txt file to make it more clear what is what :)

@alexgabi
Copy link
Contributor

alexgabi commented Apr 1, 2024

eu = harri koskor

@pastk pastk force-pushed the pastk-classif-add-scree-shingle branch from 18fef5e to c097284 Compare April 3, 2024 17:27
@pastk
Copy link
Contributor Author

pastk commented Apr 3, 2024

Included latest translation suggestions.

Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
@pastk pastk force-pushed the pastk-classif-add-scree-shingle branch from c097284 to b73cf4a Compare April 3, 2024 18:42
@rtsisyk
Copy link
Contributor

rtsisyk commented Apr 4, 2024

@pastk @vng merging?

@pastk pastk merged commit 0f6ce4f into master Apr 4, 2024
16 checks passed
@pastk pastk deleted the pastk-classif-add-scree-shingle branch April 4, 2024 10:16
@patepelo
Copy link
Contributor

patepelo commented Apr 4, 2024

Just tested via Firebase and looks good. Thanks! ✌️

We should start thinking how to render different types of beaches. Maybe changing them once user zooms in, but that's for another Issue.

@pastk
Copy link
Contributor Author

pastk commented Apr 4, 2024

Just tested via Firebase and looks good. Thanks! ✌️

Mmm.. It shouldn't be on Firebase, impossible :) It was just merged :)

@patepelo patepelo added the Styles Map drawing styles label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Styles Map drawing styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants