[tools] Fallback to Google Translations if DeepL fails #7770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Borsuk <me@alex.bio>
pastk
approved these changes
Apr 1, 2024
|
Not sure if we should merge it. What if Google translations override potentially better DeepL translations? |
|
A "potentially better DeepL translation" which is identical to the source text? A very rare case IMO :) |
|
And maybe if both deepl and google left the source EN text intact, then better to remove this lang from the output altogether. When absent it'll default to EN anyway, but it won't create an impression its a legit proof-read translation (it might be legit, but we don't know, better to leave such cases to human translators IMO). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be tested first on different cases and source languages (e.g. ru:Тест)