-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[styles] Added basic_hut and lean_to categories #7785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to remove these types from categories.txt
@map-per would you be able to finish it in a few days? |
Yes, I'm working at it at the moment 🤣 |
I included your suggestions, rebased and tested. For |
"Bivouac" is too generic term, it doesn't even imply there is a roof at all.
Please add following translations
They literally mean "Bivouac canopy/roof", not sure if it'd make sense for other languages. |
Is it normal all translations are starting lowercase? |
@organicmaps/translations long story short, a a |
Ok, used "Bivouac Hut" to emphasize it is a hut. @NeatNit Can you take another look. The translator now used a different string for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to add PT and PT-BR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New suggesting based on the clarifications (thanks for that!), still might not be ideal but I figured I'd get this in before bed. I feel way out of my depth here, if I was a frequent traveller I might know these terms but as it is I feel like I'm guessing in the dark with limited/no success finding references in my language online. Still, I hope my improvised translations are at least better than the automated ones, and better than no translation at all.
@@ -905,6 +905,8 @@ | |||
<string name="type.amenity.school">Școală</string> | |||
<!-- Weather shelter (including sun shelters and natural rock shelters). --> | |||
<string name="type.amenity.shelter">Adăpost</string> | |||
<!-- Compared to wilderness_hut its smaller and simpler, without a fireplace. --> | |||
<string name="type.amenity.shelter.basic_hut">baracă de bivuac</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Colibă
? I'm actually not sure what a good translation would be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these shelters are category_hotel ??
That's because they are similar to camp grounds and huts (see: #7785 (comment)) |
@pastk I don't like it. Please, let's keep reasonable consistency here. tourism=camp_site/alpine_hut are bookable. Shelters are not hotels. |
How does "bookable" relate to "searchable in OM"? Why would someone expect that a "Hotels" search returns something necessarily bookable? Having said that, I don't mind it either way as I guess very few people were using "Hotels" search to find camping places before and this PR won't make them use it more often. |
Maybe is a problem of language and translations, but as i see the problem is that the search is for "Hotels" and not for "Lodging". I agree that one solution could be to improve or expand the categories, or categories and subcategories. ( @pastk, remember the screenshots i posted in #7596) |
Replacing the visible "Hotels" word with "Lodging" (Ночлег) may be helpful. Am I right that shelters are not usually available in cities, so they won't pollute the map/search? What are the examples of such "shelters" btw? Any photos? |
Whoever is interested in shelters can find them by typing "shelters" or "campsites". |
How about removing |
Speaking of the hotel category. Wouldn't it be better to rename it to: "Accommodation"? |
I propose to merge this PR without category_hotel. Then make/discuss new PR with better categories/wording. |
Signed-off-by: map-per <map-per@gmx.de>
Signed-off-by: map-per <map-per@gmx.de>
Signed-off-by: map-per <map-per@gmx.de>
Signed-off-by: map-per <map-per@gmx.de>
Ok, I removed |
Signed-off-by: map-per <map-per@gmx.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for nl.
Is there a way to streamline the translations process so I don't get 34 emails, most of which irrelevant to the translation, for two words to be translated? When the translations team is tagged, all members get emails about all subsequent comments in the pull request.
@jimcarst the only way I see for now is to manually unsubscribe from PR's notifications (in the web version there is a button to the right). |
Added new categories and translations for amenity=shelter + shelter_type=basic_hut (Bivouac Box) and amenity=shelter + shelter_type=lean_to (Lean-to Shelter).
basic_hut
lean_to