[routing] Manually placed route origin is no longer replaced by current location after app restart #7786
Conversation
…ation when re-opening the app The application replaced the origin point solely based on if it had found the user's location. Added a parameter to the RouteMarkData struct which is saved alongside the start point. This is used on start up to determine if the origin point of the route should be kept or replaced with the user's location (if one is found). Signed-off-by: Fábio Gomes <gabriel.gomes@tecnico.ulisboa.pt>
|
Thanks! Is there any issue about it? What are the steps to reproduce the issue and confirm that it's fixed? Does it reproduce on iOS or Android? |
About issue #2833 The only trouble I had with this solution is just when I'm inside I sometimes don't receive a location update in time for it to register and start following the location. But that also happens in the unpatched version and I guess it's my problem for not being outside. [For Android] You can repeat the process with a route from your GPS location (by selecting only the destination point). In both cases this should result in the route being re-established with your GPS location as the origin. [For iOS] |
|
Thanks for the details! Looks like route planning mode is not restored on iOS after killing the app. And it is likely for a reason, because iOS usually doesn't kill apps in the background ) |
|
Just to be clear. By closing I meant fully closing. I'm not too familiar with iPhone, but on Android you must hit the apps on background button and swipe to close the app. I guess iOS has something similar. |
| @@ -136,6 +138,8 @@ RouteMarkData DeserializeRoutePoint(json_t * node) | |||
| FromJSONObject(node, "x", data.m_position.x); | |||
| FromJSONObject(node, "y", data.m_position.y); | |||
|
|
|||
| FromJSONObject(node, "replaceWithMyPosition", data.m_replaceWithMyPosition); | |||
There was a problem hiding this comment.
Where is this json stored? Is there a possibility that old version stored old json, and newly updated version failed to load old json? Won't it crash?
There was a problem hiding this comment.
That should be just a FromJSONObjectOptional, I believe. It will write the value to there if it exists, otherwise leave it (in this case, in the false default).
| @@ -22,6 +22,7 @@ struct RouteMarkData | |||
| bool m_isVisible = true; | |||
| bool m_isMyPosition = false; | |||
| bool m_isPassed = false; | |||
| bool m_replaceWithMyPosition = false; | |||
There was a problem hiding this comment.
Maybe
| bool m_replaceWithMyPosition = false; | |
| bool m_replaceWithMyPositionAfterRestart = false; |
?
Jean-BaptisteC
changed the title
|
What is blocking this PR from merging? |
|
I just noticed I had left an e-mail reply to this PR, but it was meant to be sent to #7964... rtsisyk sent identical questions to both PRs and I think I selected the wrong e-mail when replying 🤦. This PR wasn't in fact ready to be merged, afaik. There were unresolved discussions OP didn't resolve. @fgbg03 |
Yes. Looks like I hadn't commited the suggested change. Now that this was merged I guess it's past, but my bad. |
|
@fgbg03 it's better later than never ) |
|
I can update that, but since this is closed how do I go about changing it? |
|
Create a new PR :) |
|
Figured. On it. |
The application replaced the origin point solely based on if it had found the user's location. Added a parameter to the RouteMarkData struct which is saved alongside the start point. This is used on start up to determine if the origin point of the route should be kept or replaced with the user's location (if one is found).