Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3party] Update jansson, freetype, expat #7808

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[3party] Update jansson, freetype, expat #7808

merged 2 commits into from
Apr 5, 2024

Conversation

biodranik
Copy link
Member

Fixes recently introduced CMake warning about the symbol visibility policy CMP0063 caused by 3party libs that claim to support older CMake versions.

CMake Warning (dev) at 3party/jansson/jansson/CMakeLists.txt:351 (add_library):
  Policy CMP0063 is not set: Honor visibility properties for all target
  types.  Run "cmake --help-policy CMP0063" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

  Target "jansson" of type "STATIC_LIBRARY" has the following visibility
  properties set for C:

    C_VISIBILITY_PRESET

  For compatibility CMake is not honoring them for this target.
This warning is for project developers.  Use -Wno-dev to suppress it.

@biodranik biodranik requested review from vng and rtsisyk April 4, 2024 11:00
Signed-off-by: Alexander Borsuk <me@alex.bio>
Fixes CMake warning about the symbol visibility policy CMP0063
caused by 3party libs that claim to support older CMake versions.

Updated expat build settings. We don't use DTD and general entities.

Signed-off-by: Alexander Borsuk <me@alex.bio>
@vng vng merged commit 57402cf into master Apr 5, 2024
14 of 15 checks passed
@vng vng deleted the ab-3party-update branch April 5, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants