[android] Fix error message being unreadable in night mode

[SRSAS]

closes #6481

When the user has their device in light mode, but the app is in night mode, the error popups on EditText dialogs have the same background and font color, therefore being unreadable.

EditText error popups cannot have styles directly applied to them, thus the less disruptive fix was to call the setError method on the TextInputLayout wrapper object instead of on the EditText object.

Drawable resources were added to maintain the error icon that appears when an error popup is present.

This fix changes the error popup appearence. However, it can now more easily be customized by applying a style to the TextInputLayout element.

New error popup:

[Jean-BaptisteC]

Thanks for your contribution
IMO, it's not the right correction. With this change we return to the past -> check PR #4569
The right solution is to add a new style applied on field -> https://stackoverflow.com/questions/33709066/how-to-set-textinputlayout-error-message-colour

[SRSAS]

I continued analyzing the problem, and found out that there was an issue in the inherited styles when the app is in dark mode but the device is in light mode. This is because the MwmTheme.Night.Base style inherits from Theme.MaterialComponents.DayNight.NoActionBar.Bridge which only changes to night mode if the device is in night mode, or if the application is explicitly set in night mode.

To fix I removed the changes from the original commit, and used the UiModeManager object in the ThemeSwitcher, to change the application to the correct mode, in a new commit.

[Jean-BaptisteC]

✅ Pixel 6 - Android 14

How does it work on older devices?

[SRSAS]

I tested on Pixel 2 - Android 5 and the bug persists with API 30 or below.
I found a fix for this. Should I redo the commit?

[Jean-BaptisteC]

Amend your commit and add the new fix

[SRSAS]

Done!

[biodranik]

Thank you and respect for digging deeper! Will it properly work when the #749 is finished? E.g. when will the "As in the system" dark or light mode be used for the app theme?

P.S. Any help in finishing #749 is appreciated, it was already done for iOS...

[SRSAS]

It should work! But it must be handled correctly in the new implementation.

The android documentation recommends using UiModeManager.setApplicationNightMode() for API 31 or higher. However, I've been exploring how to set it so the app theme follows the device ui mode, but the only way I found to do it is by always using AppCompatDelegate.setDefaultNightMode() instead of the UiModeManager.

So, the way I see it, when the android implementation is done, the UiModeManager should be replaced with AppCompatDelegate, and when the app should follow the system UI mode, the MODE_NIGHT_FOLLOW_SYSTEM constant should be used.

[rtsisyk]

Wow, I forgot about existence of this file.

[SRSAS]

Should I remove this from the commit?

[SRSAS]

Hey! Anything else I should change?

[biodranik]

It's good to go, thanks, and welcome to the club!