Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Fix the circular downloading progress bar layout on the PP screen #7819

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

kirylkaveryn
Copy link
Contributor

@kirylkaveryn kirylkaveryn commented Apr 5, 2024

Closes #7782

I cannot reproduce such a huge mismatch, but I found that the device rotation will trigger the progress bar layout reloading, but the bar's backgroundLayer will not update its path.

This PR fixes this issue by refreshing the backgroundLayer's path too.

How to reproduce:

  • Start downloading some maps
  • Tap on the some PP in this region
  • Rotate the device
  • You will see a small gap between bars
  • It will be more visible if you open PP in the horizontal orientation and rotate to the vertical.

Tested on:

  • iOS 17.2 (iPhone 11 pro - device)
  • iOS 15.5 (iPhone 15 pro - simulator)

Before:
image
image

(it's hard to see it on the gif)
Simulator Screen Recording - iPhone 15 Pro - 2024-04-05 at 12 26 29

After:
Simulator Screen Recording - iPhone 13 Pro - 2024-04-05 at 12 15 35

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
@kirylkaveryn kirylkaveryn added iOS iOS development UI User interface issues labels Apr 5, 2024
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Are there any better ideas on a simpler download indicator (e.g. a text percent progress), that can also be used as a Cancel button? @euf

@biodranik biodranik merged commit 9d29851 into master Apr 5, 2024
7 checks passed
@biodranik biodranik deleted the ios/fix-downloading-progress-bar-layout branch April 5, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS development UI User interface issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ios] Circle during map download is misplaced
2 participants