Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Add PrivacyInfo with missing API declarations #7846

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

kirylkaveryn
Copy link
Contributor

Closes #7754

This PR adds PrivacyInfo file with missing API declarations as described in Documentation.

@kirylkaveryn kirylkaveryn added the iOS iOS development label Apr 7, 2024
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should we also craft appropriate string translations? Where/how they will be displayed to users?

@kirylkaveryn
Copy link
Contributor Author

Thanks! Should we also craft appropriate string translations? Where/how they will be displayed to users?

No! This declarations only for Apple.
And we should only set this new plist and add predefined values into the arrays:
image

@biodranik
Copy link
Member

This one is needed when we add iCloud support:

C617.1
    Declare this reason to access the timestamps, size, or other metadata of files inside the app container, app group container, or the app’s CloudKit container.

This one is needed when/if we add "Import bookmarks and tracks" button that will open Files app to select any kml, kmz or gpx. Is it possible @kirylkaveryn ?

3B52.1
    Declare this reason to access the timestamps, size, or other metadata of files or directories that the user specifically granted access to, such as using a document picker view controller.

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
@kirylkaveryn kirylkaveryn force-pushed the ios/fix-missing-api-declarations branch from e82ced1 to a647ccb Compare April 8, 2024 06:20
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! After rebasing, you can add the container-related file modification part into the iCloud PR (if it is used there).

@biodranik biodranik merged commit 959fd7e into master Apr 8, 2024
5 checks passed
@biodranik biodranik deleted the ios/fix-missing-api-declarations branch April 8, 2024 06:39
@kirylkaveryn
Copy link
Contributor Author

Thanks! After rebasing, you can add the container-related file modification part into the iCloud PR (if it is used there).

Thanks. I already added this task to the Todo list in my PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ios] ITMS-91053: Missing API declaration
2 participants