Minor drape fixes #7855
Merged
Minor drape fixes #7855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Borsuk <me@alex.bio>
biodranik
force-pushed
the
ab-drape-font-fixes
branch
4 times, most recently
from
ade3475
to
1cb491d
Compare
vng
reviewed
Apr 8, 2024
biodranik
force-pushed
the
ab-drape-font-fixes
branch
from
1cb491d
to
3e746b3
Compare
|
@vng PTAL |
vng
approved these changes
Apr 8, 2024
Removed hex conversion in DebugPrint for Windows, it should be done differently. Signed-off-by: Alexander Borsuk <me@alex.bio>
Signed-off-by: Alexander Borsuk <me@alex.bio>
biodranik
force-pushed
the
ab-drape-font-fixes
branch
from
3e746b3
to
d158d5d
Compare
biodranik
commented
Apr 9, 2024
| #include <utf8/unchecked.h> | ||
|
|
||
| std::string DebugPrint(std::string const & t) | ||
| { | ||
| #ifdef OMIM_OS_WINDOWS |
There was a problem hiding this comment.
@Osyotr hope that 2010 year workaround is not needed anymore? Are utf8 strings printed fine now?
There was a problem hiding this comment.
I've also removed it so should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-requisites for HB