[ios] Add default email client support to about menu

[v-lozko]

These changes are to add default email client support in the about menu. Issue #7758.

I tested it on my ipad 11 running 17.0.3

I would post a video but opening the email app does share some personal info

[biodranik]

Thanks! Did you test it with other mail clients? GMail, Proton for example?

@kirylkaveryn PTAL

[kirylkaveryn]

Please provide some screenshots (with erased personal info) of the results when you pass one subject or an array of subjects. And with different apps as @biodranik mentioned before.

[matheusgomesms]

Could you please check with Outlook as well? :)

[v-lozko]

I made edits to the code based on suggestions

Here is gmail:

here is apple native app:

here is outlook:

[v-lozko]

EDIT: I wasn't testing it appropriately, it works fine with semilcolon:

@kirylkaveryn I was just testing with multiple individuals on the email, and is the ";" most appropriate seperator? it doesn't seem to add multiple individuals to the 'to' line appropriately. Should the seperator be a comma instead?

Here is it with commas:

using the ';' made the recipient a single line

[kirylkaveryn]

@kirylkaveryn I was just testing with multiple individuals on the email, and is the ";" most appropriate seperator? it doesn't seem to add multiple individuals to the 'to' line appropriately. Should the seperator be a comma instead?

You're right! Coma is the correct symbol for the recipients joining.
I've replace ; with , and tested your branch with Spark and it works well. Also, I've tested on the ios 12.5.
So let's use your version with coma.

Thanks!

[v-lozko]

@biodranik please let me know if you need anything else for this.

[biodranik]

LGTM

[kirylkaveryn]

@biodranik I think we can merge this one!
@v-lozko thanks a lot!

[biodranik]

Thanks! So the only case when user will see the error dialog is when no any mail client is installed, right? Does it work properly on iOS 12 too?

[kirylkaveryn]

Thanks! So the only case when user will see the error dialog is when no any mail client is installed, right? Does it work properly on iOS 12 too?

I've tested on iOS 12.5 and it works well.

[v-lozko]

@biodranik let me know if there's anything else. I addressed all the comments that I saw.

[biodranik]

Thanks! A minor nit )