[search] Do not emit private swimming pools. #7870
Conversation
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
Signed-off-by: Viktor Govako <viktor.govako@gmail.com>
| @@ -8049,6 +8049,10 @@ sw:Bwawa la kuogelea | |||
| fa:استخرشنا | |||
| mr:जलतरण तलाव | |||
|
|
|||
| # Not searchable | |||
| leisure-swimming_pool-private | |||
| en:DoNotMatchThisType_OneLanguageDefinitionIsEnoughHere | |||
There was a problem hiding this comment.
What a hack! Why not searchable types should be added to categories.txt? It would be a hardly supported mess soon. There are types in categories that are searchable, and non-searchable, and there are non-searchable types not in categories...
Is it hard to keep the rule "if present in categories.txt then it's indexed and is searchable"?
There was a problem hiding this comment.
This is not a hack. We do search subtypes when the parent type is defined. To concrete subtype behaviour, need to define it manually.
There was a problem hiding this comment.
It looks like a hack. Does it make sense to document that behavior in categories.txt?
There was a problem hiding this comment.
Comment about child-parent matching is already present at the beginning of this file.
Closes #7867
Closes #3269