Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tools] Filter out pt-PT and zh translation generated by Google #7871

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[tools] Filter out pt-PT and zh translation generated by Google #7871

merged 1 commit into from
Apr 11, 2024

Conversation

biodranik
Copy link
Member

@biodranik biodranik commented Apr 9, 2024 •
edited 

    [tools] Updated translate.py script
    
    - Correct/filter out pt-PT and zh translations
    - Use ar in DeepL
    - Remove es-MX as it is not supported by Google

@biodranik biodranik requested review from vng and dvdmrtnz April 9, 2024 05:52
@biodranik
Copy link
Member Author

@dvdmrtnz does it work for you?

@dvdmrtnz
Copy link
Contributor

@biodranik It works. I think that zh needs to be filtered too. Currently it's generating zh, zh-Hans and zh-Hant, but we only use zh-Hans and zh-Hant.

@biodranik
[tools] Updated translate.py script
1961315 
- Correct/filter out pt-PT and zh translations
- Use ar in DeepL
- Remove es-MX as it is not supported by Google

Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik biodranik changed the title [tools] Filter out pt-PT translation generated by Google [tools] Filter out pt-PT and zh translation generated by Google Apr 11, 2024
@biodranik
Copy link
Member Author

@dvdmrtnz thanks! Fixed, also fixed other issues. PTAL

@dvdmrtnz
Copy link
Contributor

It's good!

@biodranik biodranik merged commit 9c7fc19 into master Apr 11, 2024
1 check passed
@biodranik biodranik deleted the ab-translate-filter-pt branch April 11, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdmrtnz dvdmrtnz dvdmrtnz approved these changes

@vng vng Awaiting requested review from vng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@biodranik @dvdmrtnz