-
-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] Add content description for search toolbar & map zoom buttons #7884
[android] Add content description for search toolbar & map zoom buttons #7884
Conversation
I have a lot of trouble squashing commits... |
|
And do not merge master branch to your PR, it complicates the rebase. |
6d5a60c
to
be68a63
Compare
@biodranik It's done ^^. |
be68a63
to
e013458
Compare
Looks like you squashed the regeneration commit into your change. It should be a separate commit. We do it to avoid merge conflicts and for easier rebasing (regeneration commit can always be easily removed, and then regenerated again by the script). |
bbcb02d
to
84ba05c
Compare
@biodranik I think it's done |
a3dc1c9
to
df5beea
Compare
@biodranik Done ^^ |
e4a0ddf
to
3926483
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PT and PT-BR reviewed (I've already manually edited the locale strings, so no need to regenerate)
e37d601
to
bf44448
Compare
bf44448
to
da0babe
Compare
a9499c2
to
783942b
Compare
@matheusgomesms It's done ^^. |
Can you rebase your branch to fix conflicts? |
783942b
to
369add3
Compare
@Jean-BaptisteC The rebase is done ^^. |
Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
369add3
to
578ea7f
Compare
@biodranik ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, and sorry for the delay!
All is in the title ^^.