Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Correct location of more menu in bookmark lists #7896

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

v-lozko
Copy link
Contributor

@v-lozko v-lozko commented Apr 11, 2024

Resolution of issue #7894

Tested on iPad Pro 11 simulator

Simulator.Screen.Recording.-.iPad.Pro.11-inch.4th.generation.-.2024-04-11.at.08.48.48.mp4

Signed-off-by: Valery Lozko <valerylozko@gmail.com>
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM
@kirylkaveryn PTAL

@kirylkaveryn kirylkaveryn self-requested a review April 12, 2024 14:09
@v-lozko
Copy link
Contributor Author

v-lozko commented Apr 16, 2024

Hello, is there anything else thats needed to merge this request?

@kirylkaveryn
Copy link
Contributor

kirylkaveryn commented Apr 16, 2024

Hello, is there anything else thats needed to merge this request?

I don't see any updates since the @biodranik and my last comments...
Can you please mark as Resolved review comments when fixed?

…r.swift

Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com>
Signed-off-by: v-lozko <156805389+v-lozko@users.noreply.github.com>
@v-lozko
Copy link
Contributor Author

v-lozko commented Apr 19, 2024

Hello, is there anything else thats needed to merge this request?

I don't see any updates since the @biodranik and my last comments... Can you please mark as Resolved review comments when fixed?

Marked resolved.

@biodranik biodranik merged commit 3b041b4 into organicmaps:master Apr 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants