Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] fix: Text trimming on the Menu screen on small screen #7605 #7898

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

v-lozko
Copy link
Contributor

@v-lozko v-lozko commented Apr 11, 2024

Sorry, i'm creating a new PR to close out issue 7605. I inadvertently closed it as it was on the main branch. I created a new branch and am pushed the same commit as before.

Here is a link to the previous PR:

#7689

Text from previous PR:
Update the xib and swift files related to BottomMenuItemCell to address the issue seen in fixed #7605 issue.

image

Fixes #6213 as seen here:

image

Tested on Simulator iPhone SE 1st gen iOS 15

…ps#7605

Signed-off-by: Valery Lozko <valerylozko@gmail.com>
@biodranik
Copy link
Member

Does it also fix #6213 ? If so, please mention it as "Fixes ..." in the PR description.

@v-lozko
Copy link
Contributor Author

v-lozko commented Apr 11, 2024

Does it also fix #6213 ? If so, please mention it as "Fixes ..." in the PR description.

Sorry, it's the same fix so it does address that issue as well. I updated the PR description

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for your contribution!

@biodranik biodranik merged commit 514423a into organicmaps:master Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ios] Text trimming on the Menu screen on small screen [ios] Make text readable
2 participants