Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github] [ios] Implement test running for the ios-check debug job #7920

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

kirylkaveryn
Copy link
Contributor

This PR Implements the iOS test running for the ios-check workflow during the debug job.

Tested on the fork.
Test running adds ~10 minutes to the workflow. This is happens because the testing process requires additional steps rather than just compiling the project:

  1. Build the project
  2. Build the tests
  3. Launch the app in the simulator
  4. Inject the tests into the running app
  5. Run the tests
  6. Quit the app
image

@kirylkaveryn kirylkaveryn added the iOS iOS development label Apr 15, 2024
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

  1. Does it make sense to store test logs as artifacts?
Test session results, code coverage, and logs:
	/Users/runner/Library/Developer/Xcode/DerivedData/omim-flvqchzzlvipeddxgcerkpudxndo/Logs/Test/Test-OMaps-2024.04.15_10-09-27-+0000.xcresult
  1. Is there a way to hide XCode compile output and only show it when compilation failed? It takes too much space in build log and its hard to find any warnings or errors.

@kirylkaveryn kirylkaveryn force-pushed the xcode/add-tests-to-the-github-actions-workflow branch from 81e69c4 to 1080675 Compare April 16, 2024 18:51
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
@kirylkaveryn kirylkaveryn force-pushed the xcode/add-tests-to-the-github-actions-workflow branch from 1080675 to f429c46 Compare April 17, 2024 11:54
@kirylkaveryn
Copy link
Contributor Author

kirylkaveryn commented Apr 17, 2024

Thanks!

  1. Does it make sense to store test logs as artifacts?
Test session results, code coverage, and logs:
	/Users/runner/Library/Developer/Xcode/DerivedData/omim-flvqchzzlvipeddxgcerkpudxndo/Logs/Test/Test-OMaps-2024.04.15_10-09-27-+0000.xcresult
  1. Is there a way to hide XCode compile output and only show it when compilation failed? It takes too much space in build log and it's hard to find any warnings or errors.

@biodranik
I update the CI workflow and as result:

  1. When tests fails the .xcresult artifact will be created and attached to the result.
    If tests doesn't fail this step will be skipped and the artifact will not be adeed.
    Failed test run:
    https://github.com/kirylkaveryn/organicmaps/actions/runs/8720798226
image image

Not failed test run (artifact step is skipped):
https://github.com/kirylkaveryn/organicmaps/actions/runs/8721380477/job/23924978475

image
  1. -quiet flag was added so the compilel will log only warnings and errors

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! Let's see how it works.

@biodranik biodranik merged commit 8637965 into master Apr 17, 2024
5 checks passed
@biodranik biodranik deleted the xcode/add-tests-to-the-github-actions-workflow branch April 17, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants