Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render shared paths with an underline, change cycleways color #7925

Merged
merged 4 commits into from Apr 24, 2024

Conversation

pastk
Copy link
Contributor

@pastk pastk commented Apr 15, 2024

Shared paths: add a cycling underline.

  • made shared paths's dashes more sparse so that cycle underline is more visible
  • change cycle lines color to blue
  • use a tad darker blue color for outdoors style
  • tuned cycle lines widths

Depends on #7878

@pastk pastk requested a review from a team April 15, 2024 17:45
@pastk
Copy link
Contributor Author

pastk commented Apr 15, 2024

shared and dedicated
image

z13 dedicated
image

z17 shared unpaved
image

Note that we might have a distinct color for paved vs unpaved dedicated cycleways too - similar to footways vs paths.

@pastk
Copy link
Contributor Author

pastk commented Apr 16, 2024

The new color is much more contrast against all backgrounds compared to the current violet. And hopefully is distinct enough from the rivers :)
Dark green could be another option.

(table source)
image

@pastk pastk force-pushed the pastk-styles-shared-paths branch from 79319b2 to 39a064f Compare April 17, 2024 12:01
@pastk
Copy link
Contributor Author

pastk commented Apr 17, 2024

  • made shared paths's dashes more sparse so that cycle underline is more visible
  • tuned cycle lines widths
  • use a tad darker color for outdoors

@pastk
Copy link
Contributor Author

pastk commented Apr 17, 2024

shared-urban-z13

shared-urban-z16

shared-od-z12

@pastk pastk force-pushed the pastk-styles-shared-paths branch 2 times, most recently from 67d2f02 to 0621e71 Compare April 17, 2024 21:20
@pastk pastk marked this pull request as ready for review April 17, 2024 21:21
@pastk pastk requested a review from a team as a code owner April 17, 2024 21:21
@pastk pastk requested review from biodranik and vng April 17, 2024 21:24
@pastk pastk force-pushed the pastk-styles-shared-paths branch from 0621e71 to 07fa2a6 Compare April 24, 2024 18:57
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
@pastk pastk force-pushed the pastk-styles-shared-paths branch from 07fa2a6 to 5db7858 Compare April 24, 2024 20:19
@vng vng merged commit a5573cc into master Apr 24, 2024
15 of 16 checks passed
@vng vng deleted the pastk-styles-shared-paths branch April 24, 2024 20:54
@pastk
Copy link
Contributor Author

pastk commented Apr 27, 2024

Another comparison with the previous color:
cycleways-zurich-z13

@map-per
Copy link
Member

map-per commented Apr 27, 2024

Tested the PR with the new map data from #8009: Sometimes the blue line is drawn on top of the white line (e.g. https://www.openstreetmap.org/way/1158116910). Looks like it has something to do with segregated.

Edit:
Looks like the bug occurs for all highway=path with segregated=yes

@pastk
Copy link
Contributor Author

pastk commented Apr 27, 2024

Tested the PR with the new map data from #8009: Sometimes the blue line is drawn on top of the white line (e.g. https://www.openstreetmap.org/way/1158116910). Looks like it has something to do with segregated.

Yeap its as intended:

  • dedicated cycleways are solid blue lines
  • segregated cycleways + footways are solid blue lines over white dashes
  • non-segregated (shared) cycleways + footways are blue lines under white dashes

It'd be better to render "segregated cycleways + footways" somehow different, e.g. a solid blue line along white dashes, but we don't have this capability ATM, see #7952

@biodranik
Copy link
Member

It's too colorful for the main style, let's move these changes to the outdoor style.

@map-per
Copy link
Member

map-per commented Apr 27, 2024

Distinguishing paths for cyclists and not for cyclists in the main style is good. Especially for cycling in cities, as the the outdoor style is not designed for dense areas.

But especially at zoom 13 dedicated cycleways and segregated cycleways + footways do are very prominent.

I would either

  • drop the distinction of segregated (this info is not really important for cycling) and always draw the blue line below the white line. This way the paths won't be that prominent.

or

  • fine tune the the prominence on lower zoom levels e.g. with higher opacity

@biodranik
Copy link
Member

biodranik commented Apr 27, 2024

Please don't turn the clean main style into a second outdoor style but for cyclists. We all agree that creating a separate cyclist-centric style is the right option.

@map-per
Copy link
Member

map-per commented Apr 30, 2024

I didn't fully figure out what you changed for cycleways, but it looks good now. The blue lines are not too prominent any more. 👍

A few days ago now
signal-2024-04-30-102450_002 signal-2024-04-30-102450_003

(Location on OSM: https://www.openstreetmap.org/node/1681356475#map=15/48.1098/11.5378)

@pastk
Copy link
Contributor Author

pastk commented Apr 30, 2024

@map-per your "now" screenshot looks strange - the most of cycleways are just gone there :/ I guess it has a different map data version, e.g. from a previous release as most of those cycleways seem to be highway=path segregated=yes and were not displayed at low zooms

In the current beta it should be like (z14):
image

Likely we'll reduce cycleways opacity a little on z13-14 before the release.

@pastk
Copy link
Contributor Author

pastk commented Apr 30, 2024

z14 from the last release for comparison
(paths are not displayed on z13)

Screenshot_20240430-133826_.jpg

@pastk
Copy link
Contributor Author

pastk commented Apr 30, 2024

Stats:

  • ~100k of highway=path segregated=yes are converted into cycleways and hence will be visible from z13
  • ~1M (out of 1.7M!) of non-segregated highway=cycleway foot=yes/designated are converted into "shared" footway-bicycle and hence will disappear on z13-14

So overall number of cycleways visible on z13-14 will significantly reduce, but in some regions like Munchen it could look vice versa.

@biodranik
Copy link
Member

Display them prominently in Outdoors, and leave not prominent at all in the main style?

@map-per
Copy link
Member

map-per commented May 2, 2024

your "now" screenshot looks strange - the most of cycleways are just gone there :/ I guess it has a different map data version, e.g. from a previous release as most of those cycleways seem to be highway=path segregated=yes and were not displayed at low zooms

Oh, yes, that was the old map data from March. I overlooked that the new map data isn't merged into master yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cycleways have poor visibility if they go through a forest because of the color. (color blind?)
4 participants