New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render shared paths with an underline, change cycleways color #7925
Conversation
The new color is much more contrast against all backgrounds compared to the current violet. And hopefully is distinct enough from the rivers :) |
79319b2
to
39a064f
Compare
|
67d2f02
to
0621e71
Compare
0621e71
to
07fa2a6
Compare
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
07fa2a6
to
5db7858
Compare
Tested the PR with the new map data from #8009: Sometimes the blue line is drawn on top of the white line (e.g. https://www.openstreetmap.org/way/1158116910). Looks like it has something to do with Edit: |
Yeap its as intended:
It'd be better to render "segregated cycleways + footways" somehow different, e.g. a solid blue line along white dashes, but we don't have this capability ATM, see #7952 |
It's too colorful for the main style, let's move these changes to the outdoor style. |
Distinguishing paths for cyclists and not for cyclists in the main style is good. Especially for cycling in cities, as the the outdoor style is not designed for dense areas. But especially at zoom 13 dedicated cycleways and segregated cycleways + footways do are very prominent. I would either
or
|
Please don't turn the clean main style into a second outdoor style but for cyclists. We all agree that creating a separate cyclist-centric style is the right option. |
I didn't fully figure out what you changed for cycleways, but it looks good now. The blue lines are not too prominent any more. 👍
(Location on OSM: https://www.openstreetmap.org/node/1681356475#map=15/48.1098/11.5378) |
@map-per your "now" screenshot looks strange - the most of cycleways are just gone there :/ I guess it has a different map data version, e.g. from a previous release as most of those cycleways seem to be In the current beta it should be like (z14): Likely we'll reduce cycleways opacity a little on z13-14 before the release. |
Stats:
So overall number of cycleways visible on z13-14 will significantly reduce, but in some regions like Munchen it could look vice versa. |
Display them prominently in Outdoors, and leave not prominent at all in the main style? |
Oh, yes, that was the old map data from March. I overlooked that the new map data isn't merged into master yet. |
Shared paths: add a cycling underline.
Depends on #7878