-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios] [bookmarks] Remove observer pattern during the category files exporting #7933
[ios] [bookmarks] Remove observer pattern during the category files exporting #7933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the functionality did not change, right? All cases (including errors) are properly handled now in the Bookmarks and Tracks dialog, right?
Yes! |
421ecf7
to
4dfa883
Compare
…ger to not use observers Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
…all files sharing Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…hods Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
4dfa883
to
d34360d
Compare
Updated with documentation! |
For now to handle the
file sharing
OM uses the observing pattern tightened to the MWMBookmarksManagers, that is too complex for this straightforward task:This is too complex because the c++ method that we interact with uses the completion handlers to return sharing results and there is no sense in wrapping the completion handle into observation:
This PR converts c++ completion handler into the objc and returns to the caller so we can share files easily with the MWMBookmarksManagers and handle result without additional overhead:
trim.BEEC13F2-FDDE-44CD-99A6-A051EA627A6E.MOV