Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Add more time in recent track #7951

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

itfarrier
Copy link

This PR implements #6462 only for iOS:

  • added 3 days duration;
  • added 1 week duration;
  • added Belarusian, English and Russian translations for them;
  • renamed Day duration as OneDay.

@biodranik
Copy link
Member

Thanks! Did you test:

  1. How much data will it take to store 3 days or a week of points?
  2. How is the app slowed down with a week of points present/rendered on the screen?
  3. Is the map still usable if you travel/move a lot? Won't points cover all the screen and distract you from everything else on the map?

@itfarrier
Copy link
Author

Thanks! Did you test:

  1. How much data will it take to store 3 days or a week of points?
  2. How is the app slowed down with a week of points present/rendered on the screen?
  3. Is the map still usable if you travel/move a lot? Won't points cover all the screen and distract you from everything else on the map?

Sorry, but of course not. Could you please guide me through the processes for addressing each of the three inquiries you've outlined?

Should I implement my own log in map/gps_tracker.hpp (cpp) for debug? Maybe we already have some approaches for above? I would be appreciate for assist me. Thanks.

@biodranik
Copy link
Member

  1. The size can be estimated from existing data size. You can check/log it programmatically on a device or simulator and then multiply by a number of seconds/minutes/hours etc.
  2. Battery usage can be tracked/compared on the release build on the same device.
  3. By knowing how many points will be stored there (I assume that in the worst case 1 point for 1 second, meaning 606024*7 = 604K points, theoretical maximum for 7 days), you can generate/simulate these points in different coordinates nearby. I think 100-200K points would be enough. And check if the app is still usable (I highly doubt it).

Check the underlying code that stores data to better understand how to simulate a lot of data there.

It would be also great to profile how CPU/GPU usage increases depending on a number of points, and where is the issue in the code that consumes a lot of CPU/GPU, which can be improved.

@Jean-BaptisteC
Copy link
Member

Can you remove merge branch commits and rebase your branch?

@itfarrier
Copy link
Author

itfarrier commented Apr 25, 2024

Can you remove merge branch commits and rebase your branch?

Yes, of course. Sorry for that. P. S. And for automatically closed and reopened by hand PR too.

@itfarrier itfarrier closed this Apr 25, 2024
@itfarrier itfarrier force-pushed the add-more-time-in-recent-track branch from 5c59b30 to 56615b3 Compare April 25, 2024 13:10
@itfarrier itfarrier reopened this Apr 25, 2024
@itfarrier itfarrier force-pushed the add-more-time-in-recent-track branch 8 times, most recently from 69538af to c3983ed Compare May 1, 2024 14:47
Fixes: organicmaps#6462

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>
Renamed for consistency

Needed for: organicmaps#6462

Signed-off-by: Dzmitry Padabed <itfarrier@icloud.com>
@itfarrier itfarrier force-pushed the add-more-time-in-recent-track branch from c3983ed to 8a76cf0 Compare May 2, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants