[qt] Make Close the default button on PPD and actived ond ESC #7956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferenc G茅czi <ferenc.gm@gmail.com>
pastk
requested changes
Apr 19, 2024
Ferenc-
force-pushed
the
ppd-close-on-esc
branch
from
77911b9
to
141c235
Compare
True. How about now? |
biodranik
reviewed
Apr 19, 2024
| @@ -26,6 +28,7 @@ void addCommonButtons(QDialog * this_, QDialogButtonBox * dbb, bool shouldShowEd | |||
|
|
|||
| QPushButton * routeToButton = new QPushButton("Route To"); | |||
| routeToButton->setIcon(QIcon(":/navig64/point-finish.png")); | |||
| routeToButton->setAutoDefault(false); | |||
There was a problem hiding this comment.
Why these calls are needed? To avoid capturing "Enter"?
There was a problem hiding this comment.
Yes, if the user doesn't move the cursor, then the enter would activate the first where the autodefault is not disabled.
biodranik
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.