Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix amenity-bbq translations #7966

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Fix amenity-bbq translations #7966

merged 2 commits into from
Apr 28, 2024

Conversation

pastk
Copy link
Contributor

@pastk pastk commented Apr 21, 2024 •
edited

A permanent apparatus to make barbecue, a barbecue grill.

@pastk pastk requested review from biodranik and a team April 21, 2024 16:27
@NeatNit
Copy link
Contributor

NeatNit commented Apr 21, 2024 •
edited

For Hebrew (he), I'm a bit divided between the auto translation על האש which refers to the activity of barbecue, and my first thought מנגל which refers to the grill being used for barbecue. If I saw the latter on the map I might think there's a physical grill there ready to be used, whereas the former... Well I'd assume someone was actively grilling there :P

@matheusgomesms
Copy link
Contributor

We are talking about the device to grill a barbecue, right?

jimcarst
jimcarst approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@jimcarst jimcarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nl ok

@NeatNit
Copy link
Contributor

NeatNit commented Apr 22, 2024

he = מנגל 👍

I'm unsubbing from notifications, if there's some change in meaning tag the translations team again

@rtsisyk
Copy link
Contributor

rtsisyk commented Apr 24, 2024

Merging?

vng
vng reviewed Apr 24, 2024
View reviewed changes
data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt
zh-Hans = 野餐地点
zh-Hant = 野餐
el = Ψησταριά μπάρμπεκιου
es = Barbacoa
Copy link
Member

@vng vng Apr 24, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, should be "Parrilla" somehow ..
At least in LATAM everybody says "Parrilla".
@organicmaps/translations-es

Copy link
Member

@biodranik biodranik Apr 27, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

es-MX = Parrilla

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. "parrilla" is ok (in es-UY it would be better "parrillero"), also "asador" or "barbacoa" is a word that should be well undestand in LATAM... there are a lot of variants and localizations in spanish, is a rich and complex language... :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, google translate makes "Barbecue Grill" -> "Parrilla de barbacoa". Is it good or not?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, google translate makes "Barbecue Grill" -> "Parrilla de barbacoa". Is it good or not?

Seems that Google translate has some bias and prefer North American words :-). "barbacoa" is understand and is good, but "parrilla" or "asador" are better choices.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so is "Parrilla de barbacoa" better than "Barbacoa" here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, only "Parrilla".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added es-MX = Parrilla

data/strings/types_strings.txt Outdated Show resolved Hide resolved
data/strings/types_strings.txt Outdated Show resolved Hide resolved
@pastk
Copy link
Contributor Author

pastk commented Apr 27, 2024

@vng @biodranik merge?

biodranik
biodranik approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with es-MX fix which in theory should be used in LATAM.

@vng which locale is used in other people's devices in BA? Does it catch es or es-MX?

@pastk
[strings] Fix amenity-bbq translations
59e8812 
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
@pastk
[strings] Regenerate for bbq
a10082d 
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
@vng vng merged commit b82d476 into master Apr 28, 2024
9 checks passed
@vng vng deleted the pastk-strings-bbq branch April 28, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgrigoriu vgrigoriu vgrigoriu left review comments

@vng vng vng left review comments

@fitojb fitojb fitojb left review comments

@muralito muralito muralito left review comments

@j13m126 j13m126 j13m126 left review comments

@matheusgomesms matheusgomesms matheusgomesms left review comments

@biodranik biodranik biodranik approved these changes

@jimcarst jimcarst jimcarst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet