Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Simplified logs output #7972

Merged
merged 2 commits into from
Apr 28, 2024
Merged

[core] Simplified logs output #7972

merged 2 commits into from
Apr 28, 2024

Conversation

biodranik
Copy link
Member

@biodranik biodranik commented Apr 22, 2024 •
edited

Example:

I(1) 0.72366 search/processor.cpp:210 SetPreferredLocale(): New preferred locale: en
D(1) 0.72374 search/processor.cpp:229 SetInputLocale(): New input locale: en locale code:
W(2) 0.72979 search/geocoder.cpp:736 CacheWorldLocalities(): Can't find World map file.

Before change:

LOG TID(1) DEBUG  7.1459e-05 platform/platform_mac.mm:135 Platform: Resources Directory: /
LOG TID(1) DEBUG 0.000118709 platform/platform_mac.mm:136 Platform: Writable Directory: /
LOG TID(1) DEBUG    0.000133 platform/platform_mac.mm:137 Platform: Tmp Directory: /
LOG TID(1) DEBUG 0.000136417 platform/platform_mac.mm:138 Platform: Settings Directory: /
LOG TID(1) INFO  0.000162875 qt/main.cpp:121 main(): Organic Maps 2024.04.22-3-c91add3a-Darwin started, detected CPU cores: 1024

@biodranik biodranik requested a review from vng April 22, 2024 22:23
@Tmpod
Copy link
Contributor

Tmpod commented Apr 24, 2024

I was actually thinking of doing something like this myself the other day, when I was looking around in logcat. This is nice!

@biodranik
[core] Simplified logs output
ab4b29f 
Example:

I(1) 0.72366 search/processor.cpp:210 SetPreferredLocale(): New preferred locale: en
D(1) 0.72374 search/processor.cpp:229 SetInputLocale(): New input locale: en locale code:
W(2) 0.72979 search/geocoder.cpp:736 CacheWorldLocalities(): Can't find World map file.

Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik
Copy link
Member Author

@vng ⬆️

vng
vng reviewed Apr 28, 2024
View reviewed changes
base/logging.cpp Outdated Show resolved Hide resolved
base/logging.cpp Show resolved Hide resolved
base/logging.cpp Outdated Show resolved Hide resolved
@biodranik
Review fixes
cef9360 
Signed-off-by: Alexander Borsuk <me@alex.bio>
@biodranik
Copy link
Member Author

biodranik commented Apr 28, 2024 •
edited

@vng fixed your comments, PTAL cef9360

@biodranik biodranik merged commit 22ace0e into master Apr 28, 2024
15 checks passed
@biodranik biodranik deleted the ab-new-logs branch April 28, 2024 12:03
Arthur-GYT pushed a commit to Arthur-GYT/organicmaps that referenced this pull request Apr 30, 2024
@biodranik @Arthur-GYT
[core] Simplified logs output (organicmaps#7972)
6f18ee1 
* [core] Simplified logs output

Example:

I(1) 0.72366 search/processor.cpp:210 SetPreferredLocale(): New preferred locale: en
D(1) 0.72374 search/processor.cpp:229 SetInputLocale(): New input locale: en locale code:
W(2) 0.72979 search/geocoder.cpp:736 CacheWorldLocalities(): Can't find World map file.

Signed-off-by: Alexander Borsuk <me@alex.bio>
kavikhalique pushed a commit to kavikhalique/organicmaps that referenced this pull request May 25, 2024
@biodranik @kavikhalique
[core] Simplified logs output (organicmaps#7972)
f01aa43 
* [core] Simplified logs output

Example:

I(1) 0.72366 search/processor.cpp:210 SetPreferredLocale(): New preferred locale: en
D(1) 0.72374 search/processor.cpp:229 SetInputLocale(): New input locale: en locale code:
W(2) 0.72979 search/geocoder.cpp:736 CacheWorldLocalities(): Can't find World map file.

Signed-off-by: Alexander Borsuk <me@alex.bio>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vng vng vng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@biodranik @Tmpod @vng