[ios] Add a loading overlay screen with an activity indicator for the bookmarks sharing #7973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bookmarks sharing Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
kirylkaveryn
added
iOS
|
(nothing needed for android) |
biodranik
approved these changes
Apr 24, 2024
biodranik
deleted the
ios/add-loading-overlay-for-the-bookmarks-exporting
branch
|
The dimmed overlay could be kept until the iOS Share Sheet is dismissed. Check background dimming behavior for sharing a file in stock Files.app or sharing an app from the Home Screen |
The sharing screen have their own dimming (in OM too) but there are no activity indicators while sharing. This small timeout while core is preparing the files... only after this delay the sharing screen can be presented. So we need some way to block the screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sharing process may take some time when there are many files and the screen isn't blocked during this process.
Current behavior:
RPReplay_Final1713864044.MOV
This PR adds a loading overlay screen with an activity indicator that disables user interaction while files are being prepared.
The Dimming effect isn't very strong (0,3 alpha) but it can be increased.
Result:
RPReplay_Final1713864028.mov
Tested on:
iPhone 11pro (17.2)
iPhone 6 (12.5)
MasOS designed for iPad