Add icon for public transport shelter #8007
Conversation
dvdmrtnz
commented
Apr 27, 2024
•
dvdmrtnz
commented
- This PR adds icon for public transport shelter by @patepelo from A better icon for public transport shelter #2319 (comment)
|
Thank you @dvdmrtnz. One important thing, this is a redesign of an icon from Roentgen. We wanted to start including them and some modifications like this one. For this PR we would have to include the credits. Here is the origin: https://github.com/enzet/Roentgen and maybe consider adding credits for this other source which we would also like to start using: GitHub:sjjb.co.uk |
|
Added Röntgen copyright notification |
Done |
| @@ -266,6 +266,10 @@ area|z16-[amenity=shelter], | |||
| node|z16-[amenity=shelter][shelter_type=lean_to], | |||
| node|z16-[amenity=shelter][shelter_type=basic_hut], | |||
| {font-size: 12; icon-min-distance: 0;} | |||
| node|z13-[amenity=shelter][shelter_type=public_transport], | |||
| {icon-image: zero-icon.svg;} | |||
There was a problem hiding this comment.
please avoid using a zero-icon hack (e.g. its invisible but user-selectable still)
please use icon-image: none; instead
There was a problem hiding this comment.
and node|z13[amenity=... is enough as we need to reset it for z13 only
(its just a minor optimization)
There was a problem hiding this comment.
Thanks. I didn't know that you could set the icon-image to none
There was a problem hiding this comment.
yeap its a relatively new improvement :)
need to disable the caption also..
dvdmrtnz
force-pushed
the
shelter
branch
2 times, most recently
from
38ab2e8
to
3c59438
Compare
| @@ -978,7 +978,7 @@ tourism-artwork-painting # icon z15- (also has captio | |||
| === 1550 | |||
|
|
|||
| amenity-shelter # icon z13- (also has caption(optional) z13-) | |||
| amenity-shelter-public_transport # icon z13- (also has caption(optional) z13-) | |||
| amenity-shelter-public_transport # icon z14- and caption z13 (also has caption(optional) z14-) | |||
There was a problem hiding this comment.
also need to add text: none; to remove the z13 caption..
There was a problem hiding this comment.
Okay! Should be good now!
Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
Signed-off-by: David Martinez <47610359+dvdmrtnz@users.noreply.github.com>
Yes. This only changes shelters tagged with |
