Save produced json in a more compact UTF-8 format #8016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isn't it zipped already? |
rtsisyk
approved these changes
Apr 28, 2024
No. We store resources uncompressed in the zip to be able to read them from there without random zip reader access. However, this can be improved for most files that are loaded as a single buffer block. Decoding JSON would be also a bit faster, as less characters should be processed. |
|
@vng hm, looks like these changes are not related to the generator's output. What is the right place to fix it? |
|
I suppose, somewhere in tools/python/maps_generator |
This change will reduce the size of generated countries.txt from 405K to 355K and speed up loading/decoding of the countries list. Signed-off-by: Alexander Borsuk <me@alex.bio>
|
@vng thanks, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will reduce the size of generated countries.txt from 405K to 355K, which is beneficial for app size and for future transfers over the wire.