[editor] Removed superfluous name=* restrictions #8036
Conversation
|
Tested it here: https://pewu.github.io/osm-history/#/node/11073340805
|
|
@map-per that's a bug, there is no need to push an empty tag. It should be cleared properly in the core, ideally even before upload/merging with osm starts, right at the moment of saving it. @kirylkaveryn You've recently touched this code in #8032 , it would be great if you cooperate to finish these changes. |
|
|
||
| void EditableMapObject::RemoveNeedlessNames() | ||
| { | ||
| RemoveBlankAndDuplicationsForDefault(); |
There was a problem hiding this comment.
Removing blank names is still needed, right? So the code above with !name.empty() should stay? Or can it be done more efficiently in another way?
CC @kirylkaveryn
There was a problem hiding this comment.
This method is used in ios to clean up empty names and prepare the list of languages that can be added to make a translation.
Maybe it would be better to set nil to the names that shouldn't be added to the list of changes (when a user adds a name but decides to skip this change later and delete translation from the list) and empty string when a user cleans up names manually?
There was a problem hiding this comment.
This is a good question: how tag removal is encoded now in the OM editor core? Is it supported at all? If not, should empty values signal that these keys should be removed from the OSM at the tag merging stage, when there are local tags, and remote tags?
Signed-off-by: map-per <map-per@gmx.de>
|
I limited the PR to only fix the identical names problem. Test: ✔️ Works as intended (https://pewu.github.io/osm-history/#/node/5433124122) |
There was a problem hiding this comment.
Thanks! @kirylkaveryn can you please confirm that the behavior on iOS is exactly the same?
|
@map-per Strange, I was sure that I had invited you to our closed chat for active contributors... Ping me (biodranik) if you are interested and have a Telegram or Matrix account. |
|
You did ask, I'm just slow, but I created a Matrix account now (and wrote you). |
|
@map-per for some reason, I don't see any messages in Elements matrix client (it s%cks btw...), can you please ping me again, so I can re-invite you? |
|
I tried again, but both times the request was instantly rejected. Maybe it works the other way round, my account is: - |
closes #1481
Removed code that prevents users from adding a multilingual name in case it is the same as
name=*. In uni lingual countries the OSM convention is that e.g.name:deshould be the same asname. (see: [Android] Editor ignores name in russian if it's the same as default name #1481)Allowed users to remove names / submit an empty name. This is e.g. helpful when the name of a POI (e.g. restaurant) changes. OM users can then update the multilingual names in languages they know and remove the wrong names in languages they don't know (no multilingual name is better than a wrong one) (see: Deleting tags not possible in the editor #6292)