Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styles] Tune cycleways #8045

Merged
merged 2 commits into from
May 2, 2024
Merged

[styles] Tune cycleways #8045

merged 2 commits into from
May 2, 2024

Conversation

pastk
Copy link
Contributor

@pastk pastk commented Apr 30, 2024

Compared to beta #8018 it makes dedicated/segregated cycleways a little more transparent at z13-14 while shared paths a little bit more visible.

Closes #8018

@biodranik
Copy link
Member

Any screenshots in good quality? )

@pastk
Copy link
Contributor Author

pastk commented May 1, 2024

Comparison with the last beta:
cycleways-barcelona-z13-beta

Comparison with the last release:
cycleways-barcelona-z13-rel

@pastk
Copy link
Contributor Author

pastk commented May 1, 2024

cycleways-luxembourg-z16-beta

@biodranik
Copy link
Member

biodranik commented May 1, 2024

Cycling lines are still too prominent for the general style, which looks dirtier now. Cyclists are only a subgroup of all our users. We don't highlight paths on the main style, why highlighting cycling paths then? Let's make them more prominent in the outdoors style, and grayish in the main style, to avoid distracting most users from the map.

@pastk
Copy link
Contributor Author

pastk commented May 2, 2024

Cycling lines are still too prominent for the general style, which looks dirtier now. Cyclists are only a subgroup of all our users. We don't highlight paths on the main style, why highlighting cycling paths then?

These PRs are not intended to "highlight" cycleways anymore than they were already. They change the color and patterns, but strive to keep the cycling / non-cycling balance as is.

If your intention is to change the status quo balance then please create a new issue for that. These set of interdependent PRs is complex enough already.

Let's make them more prominent in the outdoors style, and grayish in the main style, to avoid distracting most users from the map.

I don't think the Outdoors style is suitable for urban cycling, e.g.
Screenshot_20240502-134528_sm

@pastk
Copy link
Contributor Author

pastk commented May 2, 2024

I've reduced cycleways opacity on overview zooms a little more:

compared to the previous beta
cycleways-barcelona-z13-beta-new

compared to the last release
cycleways-barcelona-z13-rel-new

pastk added 2 commits May 2, 2024 14:07
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
Signed-off-by: Konstantin Pastbin <konstantin.pastbin@gmail.com>
@pastk pastk force-pushed the pastk-styles-tune-cycleways branch from 50d0427 to 556cce7 Compare May 2, 2024 11:09
@pastk
Copy link
Contributor Author

pastk commented May 2, 2024

@biodranik @vng PTAL!

@pastk pastk merged commit 00a6c39 into master May 2, 2024
15 checks passed
@pastk pastk deleted the pastk-styles-tune-cycleways branch May 2, 2024 12:44
@biodranik
Copy link
Member

@pastk let's activate the separate issue to add a cycling layer, with a list of TODOs, including moving these tracks from general style to cycling one. I prefer to see a clean general map without highlighting outdoor or cycling routes, many users like OM style right for that, that it's not too colorful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants