Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use custom error handling when searching for python #8046

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Don't use custom error handling when searching for python #8046

merged 1 commit into from
Apr 30, 2024

Conversation

Osyotr
Copy link
Contributor

@Osyotr Osyotr commented Apr 30, 2024

The message is too noisy to be printed on every configure run.
FATAL_ERROR part is covered by REQUIRED argument in find_package call.
Since this happens after add_subdirectory(3party), I removed its mention from comment.

@Osyotr
Don't use custom error handling when searching for python
50c9200 
Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>
biodranik
biodranik approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@biodranik biodranik merged commit e669de8 into organicmaps:master Apr 30, 2024
13 checks passed
@Osyotr Osyotr deleted the python-noise branch April 30, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biodranik biodranik biodranik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Osyotr @biodranik