[android] Remove Android Studio warnings #8073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biodranik
reviewed
May 3, 2024
| @@ -406,11 +406,10 @@ void bind(@NonNull SectionPosition position, | |||
| final long trackId = sectionsDataSource.getTrackId(position); | |||
| Track track = BookmarkManager.INSTANCE.getTrack(trackId); | |||
| mName.setText(track.getName()); | |||
| mDistance.setText(new StringBuilder().append(mDistance.getContext() | |||
There was a problem hiding this comment.
- Was it done deliberately to speed up the code? Is there any comment in git blame?
- Does it make sense to cache .getString(R.string.length) result here and maybe in some other places, where it is called repeatedly for many objects?
There was a problem hiding this comment.
Nothing in git blame
It's the only place using .getString(R.string.length)
| @@ -105,17 +105,15 @@ public String getDescription() | |||
| @Override | |||
| public String toString() | |||
| { | |||
| final StringBuilder sb = new StringBuilder("BookmarkCategory{"); | |||
| sb.append("mId=").append(mId); | |||
There was a problem hiding this comment.
Are you sure that the nee code is faster? Is there any documentation or benchmark about it?
There was a problem hiding this comment.
You're right
In the most of case, StringBuilder is more efficient -> https://dip-mazumder.medium.com/stringbuilder-vs-string-in-java-a-guide-for-optimal-memory-usage-4a284d8243ea
I have reverted changes about StringBuilder
| @@ -102,8 +103,7 @@ private FeatureCategory[] makeFeatureCategoriesFromTypes(@NonNull String[] creat | |||
| categories[i] = new FeatureCategory(creatableTypes[i], localizedType); | |||
| } | |||
|
|
|||
| Arrays.sort(categories, (lhs, rhs) -> | |||
| lhs.getLocalizedTypeName().compareTo(rhs.getLocalizedTypeName())); | |||
| Arrays.sort(categories, Comparator.comparing(FeatureCategory::getLocalizedTypeName)); | |||
android/app/src/main/java/app/organicmaps/util/log/LogsManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jean-BaptisteC <jeanbaptiste.charron@outlook.fr>
Jean-BaptisteC
force-pushed
the
rm_warnings
branch
from
a5c394f
to
40a711a
Compare
AndrewShkrob
reviewed
May 4, 2024
| final DialogInterface.OnClickListener navigateToLoginHandler = (DialogInterface dialog, int which) -> { | ||
| startActivity(new Intent(MwmActivity.this, OsmLoginActivity.class)); | ||
| }; | ||
| final DialogInterface.OnClickListener navigateToLoginHandler = (DialogInterface dialog, int which) -> startActivity(new Intent(MwmActivity.this, OsmLoginActivity.class)); |
There was a problem hiding this comment.
final DialogInterface.OnClickListener navigateToLoginHandler = (dialog, which) -> startActivity(new Intent(MwmActivity.this, OsmLoginActivity.class));or
final DialogInterface.OnClickListener navigateToLoginHandler = (_, _) -> startActivity(new Intent(MwmActivity.this, OsmLoginActivity.class));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some Android Studio warnings:
.size == 0byisEmpty()