Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios] Enable automatic signing in xcode for debug #8117

Merged
merged 1 commit into from
May 24, 2024
Merged

[ios] Enable automatic signing in xcode for debug #8117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions iphone/Maps/Maps.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4646,8 +4646,8 @@
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = AppIconDebug;
CODE_SIGN_ENTITLEMENTS = "OMaps-Debug.entitlements";
CODE_SIGN_IDENTITY = "iPhone Developer";
CODE_SIGN_STYLE = Manual;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 0;
DEVELOPMENT_TEAM = 9Z6432XD7L;
FRAMEWORK_SEARCH_PATHS = "$(inherited)";
Expand All @@ -4658,7 +4658,7 @@
MARKETING_VERSION = 2022.11.17;
OTHER_SWIFT_FLAGS = "$(inherited)";
PRODUCT_BUNDLE_IDENTIFIER = app.organicmaps.debug;
PROVISIONING_PROFILE_SPECIFIER = "CarPlay Debug";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not right. Will debug builds run on CarPlay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the description of the PR, I haven't tested CarPlay. However, iCloud also requires entitlements and it works well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand why this line has been removed. It is required to work with CarPlay in Debug.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biodranik He removed it because of this warning:

Screenshot 2024-05-13 at 16 04 57

Anyway, I tested CarPlay with auto signing and it worked even without this line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks for the update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

4683:				PROVISIONING_PROFILE_SPECIFIER = "CarPlay Release";

?

Should it also be removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release is still on manual signing so I don't think we can remove this line there.

PROVISIONING_PROFILE_SPECIFIER = "";
};
name = Debug;
};
Expand Down