-
-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios] Recover the deleted bookmark using the Recover button
on the place page
#8352
[ios] Recover the deleted bookmark using the Recover button
on the place page
#8352
Conversation
1427d65
to
805707b
Compare
to be reviewed after finishing with the current release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Does it work well with iCloud sync?
Yes! This case was tested. We do not support the PP screen state updation when the BM was updated from the cloud because the problem with the bm identification wasn't solved (this is why we reload the entire collection). |
c66ca0e
to
838c149
Compare
@biodranik I've updated the discussed issues. |
838c149
to
01f4f9d
Compare
@kirylkaveryn can you please take a look at 0630ac3 ? There is a way to avoid creating bookmark and copying bmData, by keeping and reusing the original bookmark. WDYT? |
@kirylkaveryn I've updated the commits after our discussion call. Also added Android Restore button. Can you please test it, and then squash commits into a better history, something like:
|
e0aa258
to
16fd52b
Compare
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Alexander Borsuk <me@alex.bio>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
16fd52b
to
fcb2c5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Дзякуй!
This PR allows recovering accidentally deleted bookmarks from the Place Page while the Place Page isn't closed yet.
When a user closes the Place Page or taps on another POI a recently deleted bookmark will be removed from the memory and restoring it will not be possible.
Fixes #1173
Fixes #4547
Todo:
Recover
title to Android. For now it works correctly, but without the proper word (Save
is shown where theRecover
should be). @Jean-BaptisteC can you please help with that?Screen_recording_20240601_003543.mp4