Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Import kml, kmz, gpx files using the default document picker #8410

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

kirylkaveryn
Copy link
Contributor

@kirylkaveryn kirylkaveryn commented Jun 7, 2024

Closes #7866 (comment)

This PR implements the kml, kmz, gpx files importing in iOS using the default UIDocumentPickerViewController.

nits:

  1. The icon was designed by me and requires an update @euf can you please help?
  2. The alerts are stacked one by one so it needs to be updated to handle multiple files importing at once.

Results:

ios 17.2
Simulator Screen Recording - iPhone 15 Pro - 2024-06-07 at 19 18 08

ios12.5

RPReplay_Final1717775598.MP4

@kirylkaveryn kirylkaveryn requested a review from a team as a code owner June 7, 2024 16:00
@kirylkaveryn kirylkaveryn added iOS iOS development UI User interface issues UX User eXperience, an issue with usability labels Jun 7, 2024
@euf
Copy link
Contributor

euf commented Jun 7, 2024

Hello, I'll provide new icons asap 👀

@euf
Copy link
Contributor

euf commented Jun 7, 2024

Please try these icons for both import and export (updated):

3-export
3-import

If you could share a screenshot with them, I'd be very grateful!

@kirylkaveryn
Copy link
Contributor Author

kirylkaveryn commented Jun 10, 2024

Please try these icons for both import and export (updated):

3-export 3-import

If you could share a screenshot with them, I'd be very grateful!

@euf
Thanks a lot!
Here is the result:
image

@kirylkaveryn kirylkaveryn force-pushed the ios/import-files-using-the-document-picker branch 3 times, most recently from e38f8ac to 35c1b89 Compare June 10, 2024 13:24
@kirylkaveryn
Copy link
Contributor Author

The file import is limited by one.
The multiple files import should be implemented as part on another PR.

Simulator Screen Recording - iPhone 15 - 2024-06-10 at 17 02 10

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be great to also support import of kmb files.

iphone/Maps/UI/DocumentPicker/FileType.swift Outdated Show resolved Hide resolved
@rtsisyk
Copy link
Contributor

rtsisyk commented Jun 11, 2024

Please add support for multiple files, like on Android. This is the entire purpose of this feature. One file can be imported via sharing from Files app. Please don't overthink this batch import. Android has worked for 3+ years and nobody ever worried about multiple alerts shown and possible of partial import.

@biodranik
Copy link
Member

The main purpose of this PR is to make import discoverable for users. It is at the top of UX issues right now, many users do not understand that GPX/KML/KMZ files can be imported.

The first step is to solve the main issue and allow single file import, without breaking existing code/without risks of introducing bugs.

The next step is to introduce multiple file selection and to carefully test it everywhere, including Android.

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
@kirylkaveryn kirylkaveryn force-pushed the ios/import-files-using-the-document-picker branch from 35c1b89 to d59ffaf Compare June 17, 2024 07:42
@biodranik biodranik merged commit f51b36a into master Jun 17, 2024
9 checks passed
@biodranik biodranik deleted the ios/import-files-using-the-document-picker branch June 17, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS iOS development UI User interface issues UX User eXperience, an issue with usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ios] Import kml/kmz/gpx files into the app using the default File manager
4 participants