-
-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios] Import kml, kmz, gpx files using the default document picker #8410
Conversation
Hello, I'll provide new icons asap 👀 |
@euf |
e38f8ac
to
35c1b89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it would be great to also support import of kmb files.
iphone/Maps/Bookmarks/Categories/BMCView/BMCViewController.swift
Outdated
Show resolved
Hide resolved
Please add support for multiple files, like on Android. This is the entire purpose of this feature. One file can be imported via sharing from Files app. Please don't overthink this batch import. Android has worked for 3+ years and nobody ever worried about multiple alerts shown and possible of partial import. |
The main purpose of this PR is to make import discoverable for users. It is at the top of UX issues right now, many users do not understand that GPX/KML/KMZ files can be imported. The first step is to solve the main issue and allow single file import, without breaking existing code/without risks of introducing bugs. The next step is to introduce multiple file selection and to carefully test it everywhere, including Android. |
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>
35c1b89
to
d59ffaf
Compare
Closes #7866 (comment)
This PR implements the
kml
,kmz
,gpx
files importing in iOS using the defaultUIDocumentPickerViewController
.nits:
Results:
ios 17.2
![Simulator Screen Recording - iPhone 15 Pro - 2024-06-07 at 19 18 08](https://private-user-images.githubusercontent.com/79797627/337707846-e2bd6cea-a031-4913-b021-33f326d03aab.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEzMjA3NDAsIm5iZiI6MTcyMTMyMDQ0MCwicGF0aCI6Ii83OTc5NzYyNy8zMzc3MDc4NDYtZTJiZDZjZWEtYTAzMS00OTEzLWIwMjEtMzNmMzI2ZDAzYWFiLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE4VDE2MzQwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3M2Y2ZWIwMTI5ZGZmZDk1OGM1NzQ0ZjM5NjRkYjczOWZiODBjZmI2MjU0YTc0NjliODM0YzY2ZmRmZDQ1NjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.KkTePp4E4l4ku1SfXy8Feo6wGOhqHPy-nhhuo99SSv0)
ios12.5
RPReplay_Final1717775598.MP4