This repository has been archived by the owner on Nov 25, 2020. It is now read-only.
Add option for disabling the double translation of timer metrics in statsd #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeesey
pushed a commit
to mkeesey/metrics-statsd
that referenced
this pull request
Jun 24, 2013
Metrics 3 Support
|
Any progress on that one? Would be nice to have this merged. |
|
This would be nice to have! |
|
I've just run into this -- this is still an outstanding bug, and the pull req should be applied if possible. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a "Gauge" (in statsd lingo) is sent over, statsd will compute a bunch of trends and percentile calculations for each metric. With Yammer Metrics timers and histograms, those calculations are already there, so there is no need for statsd to calculate them again.
This commit provides an option that allows statsd to just take the metrics as provided by the metrics registry and pass them along to graphite un-altered.
This commit is backwards compatible.
If merged, please kindly perform a new 2.3.1 release to maven central.