-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to embed input field on website #55
Comments
@jancborchardt Well, you could use the API to invite users to the organization... |
Yeah I know I could, but I can’t cause I’m not that deep of a developer. ;) And I thought that’s maybe what orgmanager would be useful for too. |
There’s no way it could just be using JS? Cause that would be immensely helpful for static pages like ours. |
@jancborchardt Not without exposing your Orgmanager token, I think... |
@jancborchardt Maybe a form integration can be possible, but you need a way to keep the bots out, as you can't use your own recaptcha... Ideas? |
Could we just embed an iframe with the form? |
@simonv3 Chrome and Mozilla disabled iframes for security reasons. Also, iframes are deprecated for lots of security issues. |
Huh, when did that happen? I'm fairly sure that sandstorm makes extensive use of iframes, and I use it in Chrome. Edit: I don't think I see anything here about them being insecure or being disabled: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe |
@simonv3 You're rigth. Iframes aren't deprecated. You may want to read about iframe security for pages that embed them. The problem I have is with the server-side validation. Orgmanager tries ro prevent bot signups, by providing a captcha on web request or requiring the admin's token on the API. Allowing forms would raise two security issues:
I will make some tests with OrgManager and iframes as soon as I can and report results back. |
@jancborchardt Is this still a need? It is the last issue open tagged before |
I'll let @jancborchardt be the judge of that, he created the issue :) |
@jancborchardt What do you think? |
@jancborchardt @simonv3 I think I'm going to move this to |
It would really be cool still – as said on #56 (comment)
|
@jancborchardt So then, this can be closed in favour of #56? |
It would be really cool if we could put an input field right on the website so people can join directly from there.
cc @m1guelpf @bnvk @simonv3 :)
The text was updated successfully, but these errors were encountered: