Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub OAuth option in the Join page #56

Closed
jancborchardt opened this issue Feb 22, 2017 · 10 comments
Closed

GitHub OAuth option in the Join page #56

jancborchardt opened this issue Feb 22, 2017 · 10 comments

Comments

@jancborchardt
Copy link
Member

Instead of https://orgmanager.miguelpiedrafita.com/join/4183553 it would be much nicer to have https://orgmanager.miguelpiedrafita.com/join/opensourcedesign :)

Also – get a real nice domain which isn’t just a subdomain maybe. ;)

@m1guelpf
Copy link
Member

@jancborchardt That ID is used to prevent bruteforce, but moving to org name is a good idea.
Also, I believe open-source projects should be free, but if someone wants to donate for a domain, it'd be awesome. Also, the project was created to be selfhosted, so the hosted version isn't that important.

@m1guelpf m1guelpf added this to the v3.0 milestone Feb 22, 2017
@m1guelpf m1guelpf added the v3.0 label Feb 22, 2017
@m1guelpf m1guelpf mentioned this issue Feb 22, 2017
2 tasks
@jancborchardt
Copy link
Member Author

Yeah, I mean at least it could be optional to switch to the readable name. :)

@m1guelpf
Copy link
Member

m1guelpf commented Feb 22, 2017

@jancborchardt d6208b8 added pretty URLs! 🎉
You can now point users to {orgmanager-url}/o/{org-name} and it'll redirect to {orgmanager-url}/join/{org-id}!

@m1guelpf
Copy link
Member

m1guelpf commented Apr 14, 2017

@jancborchardt Would you be interested in something like custom domains? For example: join.opensourcedesign.net shows the OrgManager join page for OSD. (and maybe that would also make #55 unnecesary)

@m1guelpf m1guelpf reopened this Apr 14, 2017
@jancborchardt
Copy link
Member Author

Sure, that would be cool! :) Then we could add a DNS entry.

Let me know what I need to do @m1guelpf

@jancborchardt
Copy link
Member Author

I think though that »Make it possible to embed input field on website« #55 would be much cooler though. :) That also gets everyone who lands on your page to get involved very quickly. Sure, with a button you could just link to the orgmanager page, but abstracting the whole thing away through just an input field or a button which launches Github auth would be even cooler.

@m1guelpf
Copy link
Member

@jancborchardt What about a button that uses GitHub OAuth to get the user username and then invites them?

@jancborchardt
Copy link
Member Author

Sounds pretty good, like a very simple flow! :)

@m1guelpf m1guelpf changed the title Use actual name of organizations on Github as the link GitHub OAuth option in the Join page Apr 23, 2017
@m1guelpf m1guelpf added v4.0 and removed v3.0 labels Apr 23, 2017
@m1guelpf m1guelpf modified the milestones: v4.0, v3.0 Apr 23, 2017
@m1guelpf
Copy link
Member

Blocked by #249

@m1guelpf m1guelpf mentioned this issue Apr 28, 2017
8 tasks
@m1guelpf m1guelpf modified the milestone: v4.0 Sep 4, 2017
@m1guelpf
Copy link
Member

m1guelpf commented Sep 6, 2017

Closed in favour of #277.

@m1guelpf m1guelpf closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants