Config.sh and Run.sh return "Must not run with sudo"

[montanizstills]

Self-Hosted Runner Config Script

Bug

Body

I am not sure if this is a bug or purposeful but the config.sh and run.sh scripts have a clause where any user with the RUNER_ALLOW_AS_ROOT flag turned on cannot execute them. Why? Inspecting the svc.sh script it will run as a root-like user. But it must be first configured with the config script which does not like root-like users. Can someone explain this logic?

[Yarden-zamir]

Maybe

RUNNER_ALLOW_RUNASROOT

instead of

RUNER_ALLOW_AS_ROOT

[montanizstills]

Yes, I have a typo in my issue, but the problem remains the same. Git must fix it. An alternative would be to create a user and transfer ownership of files, but the action file will run as a 'sudoer' thus defeating the purpose.

[Yarden-zamir]

I just tested it myself and the config.sh works as expected. I ran

sudo RUNNER_ALLOW_RUNASROOT=true ./config.sh

which in your case will be

RUNNER_ALLOW_RUNASROOT=true ./config.sh

And the Must not run with sudo message did not appear and the script poceeded correctly.

if we go into the script we can see the check itself

#line 6
if [ $user_id -eq 0 -a -z "$RUNNER_ALLOW_RUNASROOT" ]; then
    echo "Must not run with sudo"
    exit 1
fi

This conditional expression is checking two conditions:

The value of the variable $user_id is equal to 0. (meaning root user)
The environment variable $RUNNER_ALLOW_RUNASROOT is an empty string.

If following it sill doesn't work, please provide more details on what you are running and the steps you took along the way.

[mdhasan76]

I just tested it myself and the config.sh works as expected. I ran

sudo RUNNER_ALLOW_RUNASROOT=true ./config.sh

which in your case will be

RUNNER_ALLOW_RUNASROOT=true ./config.sh

And the Must not run with sudo message did not appear and the script poceeded correctly.

if we go into the script we can see the check itself

#line 6
if [ $user_id -eq 0 -a -z "$RUNNER_ALLOW_RUNASROOT" ]; then
    echo "Must not run with sudo"
    exit 1
fi

This conditional expression is checking two conditions:

The value of the variable $user_id is equal to 0. (meaning root user) The environment variable $RUNNER_ALLOW_RUNASROOT is an empty string.

If following it sill doesn't work, please provide more details on what you are running and the steps you took along the way.

Thanks it works fine