Use two separate buttons for 'Create pull request' and 'Create draft pull request' instead of a dropdown #63829
Unanswered
brianlove
asked this question in
Pull Requests
Replies: 1 comment
-
Tangentially related, but I find the fact that the draft/non-draft setting in the dropdown is remembered for subsequent PRs to be an anti-feature. As someone that opens 99% non-draft and 1% draft PRs, a draft PR screws me up almost every time without fail later, because I don't usually want my PRs to be drafts except for rare cases, but muscle memory makes me click the green button and I accidentally open drafts that way when I didn't mean to. Splitting the button as proposed above would let get me my muscle memory back and not make this mistake. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Select Topic Area
Product Feedback
Body
When creating a pull request, I find the current interface for selecting whether to create a PR that's ready for review versus a draft PR to be fairly clunky - there's a button, but also a dropdown, and selecting the other option from the dropdown changes the mode of the button instead of actually submitting something. This creates extra steps when submitting a PR and the similar wording of the various options (and same visual style) requires careful attention to which mode is currently active.
Instead, I would like to suggest that instead of the dropdown, separate buttons for 'Create pull request' and 'Create draft pull request' be present in that location. 'Create pull request' would be the primary (green) button, and be on the right since it's generally the default action. Meanwhile, 'Create draft pull request' would be a secondary (gray) button to the left. I've created the following mockup:
This would simplify the interface (fewer bits of hidden interface), reduce clicks (since there's no need to open the dropdown), and streamline the PR creation process since the different actions would be visually distinct.
Beta Was this translation helpful? Give feedback.
All reactions