Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package for RPM #159

Closed
orhun opened this issue Apr 28, 2023 · 4 comments
Closed

Package for RPM #159

orhun opened this issue Apr 28, 2023 · 4 comments
Labels
feature/request New feature or request help wanted Extra attention is needed

Comments

@orhun
Copy link
Owner

orhun commented Apr 28, 2023

Is your feature request related to a problem? Please describe.

It would be nice to distribute an RPM package as a part of the releases.

Describe the solution you'd like

Generate an RPM via cargo-generate-rpm during continuous deployment and publish it on GitHub releases.

Describe alternatives you've considered

None.

Additional context

See this example: fujiapple852/trippy#410
@orhun orhun added feature/request New feature or request help wanted Extra attention is needed labels Apr 28, 2023
@orhun orhun self-assigned this Apr 28, 2023
@radusuciu
Copy link
Contributor

Since I've been digging around in the CD workflow I can take a crack at this if you'd like. The example seems simple enough.

@orhun
Copy link
Owner Author

orhun commented May 30, 2023

Please go ahead @radusuciu!

Btw I'm pretty busy lately so I couldn't check your other PR yet, will get to it soon. Thanks!

@orhun orhun assigned radusuciu and unassigned orhun May 30, 2023
@radusuciu
Copy link
Contributor

Alright, will be 1-2 weeks before I have a PR for this so if you or anyone beats me to it please go ahead!

Regarding the PyPI PR -- no worries, I've done some testing work and made some fixes. I deleted a few interim updates to reduce the noise for when you have time for final review.

orhun added a commit that referenced this issue Sep 30, 2023
@orhun
feat(ci): distribute RPM package (#159)
baf4da8
@orhun
Copy link
Owner Author

orhun commented Sep 30, 2023

I handled this in baf4da8

Thanks again @radusuciu!

@orhun orhun closed this as completed Sep 30, 2023
@p-linnane p-linnane mentioned this issue Sep 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/request New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@radusuciu @orhun