Missing/wrong pull requests for commits #436
Labels
bug
Something isn't working
help wanted
Extra attention is needed
integration
Related to GitHub/GitLab integration
Describe the issue
The current approach to associate commits with the pull requests is the following:
merge_commit_sha
of the pull request matches the SHA of the commit.This poses a couple of problems when the pull request is not squashed but rebased.
Take #360 for example (it is rebased).
git cliff -c github
outputs:However, it should be:
Additional context
I don't know how to fix this yet since it is the limitation of the data we get from the GitHub API. In the perfect world,
/commits
endpoint would also return the associated pull request number so that we don't need to fetch the pull requests and do some hacky comparison.Alternatively, we could use
<commit>/pull
API but that just means sending a request for each commit which adds up to a lot.The text was updated successfully, but these errors were encountered: